Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pages metadata in the beatmap. #1768

Merged
merged 3 commits into from
Nov 29, 2022
Merged

Implement pages metadata in the beatmap. #1768

merged 3 commits into from
Nov 29, 2022

Conversation

andy840119
Copy link
Member

@andy840119 andy840119 commented Nov 29, 2022 •
edited
Loading

Beatmap format part of issue #1766.

What's done in this PR:

  • Create the metadata class.
  • Add the property into the beatmap.
  • Add the page property into the hit-object and mark as json ignore.
  • Use beatmap processor to update the property.

Note that the structure is follow how ControlPointInfo did in the osu.game.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 29, 2022
@andy840119 andy840119 merged commit 05c3e30 into karaoke-dev:master Nov 29, 2022
@andy840119 andy840119 deleted the implement-pages-in-the-beatmap branch November 29, 2022 17:14
@andy840119 andy840119 added the enhancement New feature or request label Nov 30, 2022
@andy840119 andy840119 added this to the 2022.1231 milestone Nov 30, 2022
@andy840119 andy840119 mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request size/L
Projects
None yet
Milestone
2022.1231
Development

Successfully merging this pull request may close these issues.
1 participant
@andy840119