Skip to content

Implement the classic stage info auto-generator. #1764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andy840119 opened this issue Nov 27, 2022 · 8 comments
Closed

Implement the classic stage info auto-generator. #1764

andy840119 opened this issue Nov 27, 2022 · 8 comments
Labels
enhancement New feature or request
Milestone

Comments

@andy840119
Copy link
Member

Separate part of #1755.
Should think about is it possible to auto-generate the time just by layout index?
Or:

  • Should record more info or relation in the layout class
  • Should record the start time and end time by user(Use this way only if there's no better choice.)

https://youtu.be/vYqWRiAA4_Y
Here's the video that better for thinking.
And it's the effect that classic layout mode wants to do.

@andy840119 andy840119 added the enhancement New feature or request label Nov 27, 2022
@andy840119
Copy link
Member Author

andy840119 commented Nov 27, 2022

Note:
Maybe can make something like time-point.
At this point, can close the list of lyrics and open preparing lyric.

[Update]
Not really sure can it ba a part of control point?
Or should be be the control point because it's too specific?

@andy840119
Copy link
Member Author

andy840119 commented Nov 27, 2022

如果使用 control point 來控制這件事情的話
可以把這種 control point 想像成是用來控制 lyric 的 start and end time. (maybe called lyric life time control point?)
並且裡面會記錄:

  1. 把哪個 hit-object 打開或是關閉
  2. 只記錄和哪個 Hit-object 有關聯? 好像已經足夠去決定要開啟或是關閉哪個 Lyric

@andy840119
Copy link
Member Author

andy840119 commented Nov 27, 2022

I guess will be able to create control point for customized ruleset, right?

[update]
Not really sure should do this or not.
Because this control point is for class layout only.

@andy840119
Copy link
Member Author

andy840119 commented Nov 27, 2022

https://youtu.be/alR4Ac9evFg?t=93
用英文有點難描述,不過可以看到這邊會有類似 "Page" 的概念
字幕顯示的行數也和 page 有點關係

在大部份情況下,一個 page 會包含兩行或是三行
少數有三行跨兩個 page 的情況

或許 lyric editor 需要有一個地方去指定不同 lyric 會對應到哪一個 page (或是專門開一個 editor?)
但目前第一版不會有 note
設計起來會有點頭痛

另外 page 的定義應該是:

  1. 大約一口氣可以唱完的長度?
  2. 可能會被 layout 影響到?

目前並不明確

@andy840119 andy840119 changed the title Should think about should it be possible to auto-generate the lyric time. Implement the classic stage info auto-generator. Jan 7, 2023
@andy840119
Copy link
Member Author

Guess should be renamed to the ClassicLyricLayoutCategoryGenerator?
Because should be only able to generate the layout.

@andy840119
Copy link
Member Author

andy840119 commented Jan 7, 2023

Not really sure should have feature to select the range of lyrics to generate?

@andy840119
Copy link
Member Author

Or should we just make the generator generate the default layout position and assign to the lyric?
e.g. User is able to generate 3 layouts and only cycle two of them?

@andy840119
Copy link
Member Author

Implemented in the #1950 and #1952

And this issue is similar to the #1904

@andy840119 andy840119 added this to the 2023.0520 milestone Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant