Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement page generator. #1803

Open
andy840119 opened this issue Dec 18, 2022 · 4 comments
Open

Implement page generator. #1803

andy840119 opened this issue Dec 18, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@andy840119
Copy link
Member

Part of #1766
Because all of the generators currently is for lyric only.
So need to make the new structure for able to support other input/output properties.

Also, all generators for now will clear the exist property, but it might have request not to clear them.

@andy840119 andy840119 added the enhancement New feature or request label Dec 18, 2022
@andy840119
Copy link
Member Author

andy840119 commented Dec 18, 2022

The config for the generators:

  • Min Accept time
  • Max accept time

The config in the UI

  • Min accept time
  • Max accept time
  • Clear(or Reset) the current pages.

@andy840119
Copy link
Member Author

Should re-design the generator location:

  • Beatmap
    • Pages
    • ClassicLayout
  • Lyric
    • Laguage
    • Notes
    • ReferenceLyric

@andy840119
Copy link
Member Author

And note that we already have the GeneratorSelector
Should rename to the LyricGeneratorSelector
Each type (lyric, beatmap) should have different generator selector structure.

@andy840119
Copy link
Member Author

todo:

  • should deal with the case with page already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant