Reduce unneeded calls for mootools

[dgrammatiko]

Executive summary

Lately Joomla made some shift from mootools to jquery, for a number of scripts, thanks to the work of people participated on Joomla! Google Summer of Code Program in 2013. Although we use, let’s say, form validation in conjunction with jquery we still do call mootools as well. Which is wrong, as we increase the http requests without any benefits! So this PR tries to bring some sanity to what framework is loaded, by:
1 Removing uneeded calls for mt in cms/html/behavior.php
2 Corrects the multiselect.js script (and the uncompressed) to remove an error (Joomla is undefined)
3 Correct the view of administrator/com_users/views/mail/tmpl/default.php (chosen is called but not core.js)
4 Move all the calls from toolbar buttons to their respective layouts

Testing

UPDATE PLEASE SEE THE TESTING INSTRUCTION ON THE PRs

Introduce jquery formvalidator for com_xxxxx
BUT ALSO CHECK THESE:

administrator/index.php?option=com_checkin should demonstrate multiselect without mt
administrator/index.php?option=com_users&view=mail should demonstrate form sent and validate without mt
administrator/index.php?option=com_modules should demonstrate multiselect and combobox without mt
http://localhost/administrator/index.php?option=com_admin&view=sysinfo should demonstrate highlighter.js without mt
Logout and log in to demonstrate the use of noframes without mt.

[Fedik]

nice catch 👍

[dgrammatiko]

If this gets merged the documentation here needs also to be updated. Actually this is already outdated as the validate.js is jquery dependent since 3.3

[smanzi]

@DGT41 administrator/index.php?option=com_users&view=mail issues errors (missing subject and/or message) in pop (no mt, just basic pop-up...) Is this expected?

[dgrammatiko]

@smanzi Yes this is expected behavior

[smanzi]

@test success

[anibalsanchez]

@test success

• administrator/index.php?option=com_checkin should demonstrate multiselect without mt
  OK

-administrator/index.php?option=com_users&view=mail should demonstrate multiselect without mt
OK

• administrator/index.php?option=com_modules should demonstrate multiselect and combobox without mt
  OK
• administrator/index.php?option=com_admin&view=sysinfo should demonstrate highlighter.js without mt
  OK ... but sysinfo does not load highlighter.js. Tested with com_finder in front-end site, searching for a keyword and disabling everything but "Highlight Search Terms"
• Login - Logout without mt
  OK
  
  
  This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4888.

[Hackwar]

Simply pull in the changes. You don't need to rebase.

[dgrammatiko]

I done something pretty stupid when I created this, instead of the proper origin: joomla-cms/staging I used my forked one. If I do anything this will be ruined big time! But now I figure it out how to use tower 😄.
Seriously now, sorry for this awkward situation

[dgrammatiko]

When there is a will there’s a way

[smanzi]

using gitshell I think it is:

git checkout yourbranch
git fetch upstream/pull/nnnn
git merge

[dgrammatiko]

@smanzi Thanks I am using a gui tool tower, which for some time I was misusing it. But thanks for the info!

[smanzi]

I don't know with your GUI, but with the GUI provided by GitHub there are things you can't do and must use git commands (in gitshell, which is provided together with the GUI)

[roland-d]

@DGT41 Thanks, PR applies no problem and Travis is happy.
@test: Works as expected.

[dgrammatiko]

@roland-d Any guidance for the documentation update? What we have is already outdated as from 3.3 we use jquery validation code

[roland-d]

@DGT41 Let's ask @Hutchy68 as he is the one leading the documentation efforts. What can be done about the documentation Tom?