Skip to content

Conversation

@dgrammatiko
Copy link
Contributor

Executive summary

This PR converts the form validation on com_config to use plain jquery (no mootools call on every form).
Also NO MORE INLINE SCRIPTS!

Testing

  1. Apply first PR Reduce unneeded calls for mootools #4888 (!important)
  2. Apply this PR
  3. In the admin area create new menu items for contact (categories, category, etc)
  4. go to the new menus and test that everything is still OK

If no javascript errors are logged in your browser’s console and the functionality remains the same, your test is passing in any other case please report the errors here

Please also check these:
administrator/index.php?option=com_checkin should demonstrate multiselect without mt
administrator/index.php?option=com_users&view=mail should demonstrate form sent and validate without mt
administrator/index.php?option=com_modules should demonstrate multiselect and combobox without mt
Logout and log in to demonstrate the use of noframes without mt.

@dgrammatiko
Copy link
Contributor Author

@infograf768 can I ask for a rerun of travis here? People scared on the error message, and walk away

@infograf768
Copy link
Member

Travis relaunched. Can you /test OK #5121 ?

@Hackwar
Copy link
Member

Hackwar commented Nov 17, 2014

@test success
Again, the tooltips are misaligned.

@dgrammatiko dgrammatiko mentioned this pull request Nov 17, 2014
@anibalsanchez
Copy link
Contributor

@test success

@roland-d
Copy link
Contributor

Moving to RTC as we have 2 successful tests.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5112.

@brianteeman brianteeman added the RTC This Pull Request is Ready To Commit label Nov 29, 2014
@Bakual Bakual added this to the Joomla! 3.4.0 milestone Dec 2, 2014
@Bakual
Copy link
Contributor

Bakual commented Dec 2, 2014

Merged into staging. Thanks!

@Bakual Bakual closed this in f442c23 Dec 2, 2014
@dgrammatiko dgrammatiko deleted the _form_jq_com_contact_frontend branch December 11, 2014 15:22
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants