-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Introduce jquery formvalidator for com_redirect #5052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@test success |
|
I have applied the patch on 3.3.6, but I'm getting: An error has occurred. 500 Layout default_batch not found |
|
@anibalsanchez That's strange... I've tested it on 3.3.6 too: no problem. Do you use com_patchtester for applying PRs? |
|
@anibalsanchez Checking the repo 3.3.6 I see that this file doesn’t exist there. It must have been added later on |
|
Guys, I just tested it again, just to be sure, and... no problem! What's going on here?? |
|
@anibalsanchez can it be that you have other unrelated PRs applied? Unhappily in com_patchtester we don't have a filter to see which one are currently applied and we must scroll the whole list... |
|
@smanzi I already requested one more view in com_patchtester, take a look here ianmacl/patchtester#9 |
|
It is a clean installation for these tests ... anyway I'm re-installing and keeping an eye on patching consistency. |
|
@DGT41 Ooops... I just did the same request here: joomla-extensions/patchtester#54 |
|
@DGT41 Actually not the same request. I think you made yours in the wrong repo... |
|
@roland-d this, as well, got 2 good tests (you have to go through the comments) |
|
@DGT41 Thanks for the info. That is why we are trying to get people to use the Test results module on every issue, so we can easily see how many tests it has. Reading long commments isn't always as clear ;) |
|
Moving to RTC as we have 2 successful tests. |
|
@DGT41 Yeah the current workflow isn't ideal. Thanks for the link, I will comment there. |
|
@DGT41 there are problems with this... And I cannot save the redirection... |
|
Also, tooltips not correctly rendered... |
|
Fixed, for tooltips there is #5137 |
Executive summary
This PR converts the form validation on com_redirect to use plain jquery (no mootools call on every form