Skip to content

Conversation

@dgrammatiko
Copy link
Contributor

Executive summary

This PR converts the form validation on com_redirect to use plain jquery (no mootools call on every form

@smanzi
Copy link

smanzi commented Nov 11, 2014

@test success

@anibalsanchez
Copy link
Contributor

I have applied the patch on 3.3.6, but I'm getting:

An error has occurred. 500 Layout default_batch not found

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5052.

@smanzi
Copy link

smanzi commented Nov 13, 2014

@anibalsanchez That's strange... I've tested it on 3.3.6 too: no problem. Do you use com_patchtester for applying PRs?

@dgrammatiko
Copy link
Contributor Author

@anibalsanchez Checking the repo 3.3.6 I see that this file doesn’t exist there. It must have been added later on

@smanzi
Copy link

smanzi commented Nov 13, 2014

Guys, I just tested it again, just to be sure, and... no problem! What's going on here??

@anibalsanchez
Copy link
Contributor

Yes, patchtester applies it Ok... weird ... how a fresh install have become corrupted in com_redirect.

I have applied #4888 and #5052 in other site, it works OK. @test success!

@smanzi
Copy link

smanzi commented Nov 13, 2014

@anibalsanchez can it be that you have other unrelated PRs applied? Unhappily in com_patchtester we don't have a filter to see which one are currently applied and we must scroll the whole list...

@dgrammatiko
Copy link
Contributor Author

@smanzi I already requested one more view in com_patchtester, take a look here ianmacl/patchtester#9

@anibalsanchez
Copy link
Contributor

It is a clean installation for these tests ... anyway I'm re-installing and keeping an eye on patching consistency.

@smanzi
Copy link

smanzi commented Nov 13, 2014

@DGT41 Ooops... I just did the same request here: joomla-extensions/patchtester#54

@smanzi
Copy link

smanzi commented Nov 13, 2014

@DGT41 Actually not the same request. I think you made yours in the wrong repo...

@dgrammatiko
Copy link
Contributor Author

@roland-d this, as well, got 2 good tests (you have to go through the comments)

@roland-d
Copy link
Contributor

@DGT41 Thanks for the info. That is why we are trying to get people to use the Test results module on every issue, so we can easily see how many tests it has. Reading long commments isn't always as clear ;)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5052.

@roland-d
Copy link
Contributor

Moving to RTC as we have 2 successful tests.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5052.

@dgrammatiko
Copy link
Contributor Author

@roland-d I can see all the hard word needed in the current workflow, that’s why I proposed this but it was turned down...

@roland-d
Copy link
Contributor

@DGT41 Yeah the current workflow isn't ideal. Thanks for the link, I will comment there.

@brianteeman brianteeman added the RTC This Pull Request is Ready To Commit label Nov 29, 2014
@smanzi
Copy link

smanzi commented Nov 30, 2014

@DGT41 there are problems with this...
Creating a new redirection I get in console:

TypeError: document.formvalidator is null index.php:30
Use of getAttributeNode() is deprecated. Use getAttribute() instead. jquery-migrate.min.js:2
TypeError: b is null core.js:1

And I cannot save the redirection...

@smanzi
Copy link

smanzi commented Nov 30, 2014

Also, tooltips not correctly rendered...

@dgrammatiko
Copy link
Contributor Author

Fixed, for tooltips there is #5137

@smanzi
Copy link

smanzi commented Nov 30, 2014

Confirmed!
Tooltips malfunction was related, but it is now OK!

@test success for this PR
Tested the set of: #5046 #5048 #5049 #5050 #5051 #5052 #5053 #5054 #5056 #5058 #5113 #5255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants