Skip to content

Conversation

@dgrammatiko
Copy link
Contributor

Executive summary

This PR converts the form validation on com_messages to use plain jquery (no mootools call on every form

@smanzi
Copy link

smanzi commented Nov 11, 2014

@DGT41 Unable to select recipient (users list not populated), but I have the same behavior without your PR! New issue??

@dgrammatiko
Copy link
Contributor Author

@smanzi You just found a new bug! 👍

@smanzi
Copy link

smanzi commented Nov 11, 2014

@DGT41 do you want open new issue and try a PR? I'm currently busy fixing up JHtmlBoostrap::renderModal() (yes, it has issues!), but after that I can give a look too...

@dgrammatiko
Copy link
Contributor Author

@smanzi I am kinda busy right now, maybe later

Try to see the code in Bootstrap 3.0 and maybe port it to 2.3.2? Just an idea...

@smanzi
Copy link

smanzi commented Nov 13, 2014

@test success

@DGT41 there was no bug here! It was only due to the fact that I (and probably you too...) didn't have any other user beside ourselves enabled to send/receive messages. I think it must be an Administrator or Super User. Try adding a new Administrator and it will work. You should probably add this to your test instructions...

The question now is: if the recipient must be an Administrator/Super User, why in the modal for user selection it is possible to select also the other user groups for filtering? 😏

@anibalsanchez
Copy link
Contributor

@test success

I agree, UI is inconsistent. I think messages component is not used and it can be removed (similar case to weblinks).

@smanzi
Copy link

smanzi commented Nov 13, 2014

... and Banners and Contacts and (IMHO) Newsfeeds

@dgrammatiko
Copy link
Contributor Author

@anibalsanchez @smanzi my list of useless stuff is a little bit longer 😃

@smanzi
Copy link

smanzi commented Nov 13, 2014

@DGT41 @anibalsanchez If we start looking into plugins it can be way longer!!

@anibalsanchez
Copy link
Contributor

Yeah! Let's kick them out.

@dgrammatiko
Copy link
Contributor Author

@anibalsanchez @smanzi According to the roadmap in two days time will have 3.5 without com_newsfeeds, com_banners, com_contacts, com_search, com_finder, com_redirect, com_messages. But then again 3.4 is not yet released...

@anibalsanchez
Copy link
Contributor

Well, let's wait for the next version.

@Bakual
Copy link
Contributor

Bakual commented Nov 13, 2014

The roadmap is flexible 😄
If it's ready before the release of 3.4 beta, it can be considered for 3.4. If not, it will go into 3.5.

@dgrammatiko
Copy link
Contributor Author

@Bakual Thomas I would like to help there, but I guess someone has to make all these repos...

@Bakual
Copy link
Contributor

Bakual commented Nov 13, 2014

I think ss soon as the 3.4 is released, we will create all those repos.

@dgrammatiko
Copy link
Contributor Author

@roland-d this one got 2 good test :)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5048.

@roland-d
Copy link
Contributor

Moving to RTC, 2 successful tests.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5048.

@brianteeman brianteeman added the RTC This Pull Request is Ready To Commit label Nov 29, 2014
@smanzi
Copy link

smanzi commented Nov 30, 2014

@test success for this PR
Tested the set of: #5046 #5048 #5049 #5050 #5051 #5052 #5053 #5054 #5056 #5058 #5113 #5255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants