- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3.7k
Introduce jquery formvalidator for com_messages #5048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @DGT41 Unable to select recipient (users list not populated), but I have the same behavior without your PR! New issue?? | 
| @smanzi You just found a new bug! 👍 | 
| @DGT41 do you want open new issue and try a PR? I'm currently busy fixing up JHtmlBoostrap::renderModal() (yes, it has issues!), but after that I can give a look too... | 
| @smanzi I am kinda busy right now, maybe later Try to see the code in Bootstrap 3.0 and maybe port it to 2.3.2? Just an idea... | 
| @test success @DGT41 there was no bug here! It was only due to the fact that I (and probably you too...) didn't have any other user beside ourselves enabled to send/receive messages. I think it must be an Administrator or Super User. Try adding a new Administrator and it will work. You should probably add this to your test instructions... The question now is: if the recipient must be an Administrator/Super User, why in the modal for user selection it is possible to select also the other user groups for filtering? 😏 | 
| @test success I agree, UI is inconsistent. I think messages component is not used and it can be removed (similar case to weblinks). | 
| ... and Banners and Contacts and (IMHO) Newsfeeds | 
| @anibalsanchez @smanzi my list of useless stuff is a little bit longer 😃 | 
| @DGT41 @anibalsanchez If we start looking into plugins it can be way longer!! | 
| Yeah! Let's kick them out. | 
| @anibalsanchez @smanzi According to the roadmap in two days time will have 3.5 without com_newsfeeds, com_banners, com_contacts, com_search, com_finder, com_redirect, com_messages. But then again 3.4 is not yet released... | 
| Well, let's wait for the next version. | 
| The roadmap is flexible 😄 | 
| @Bakual Thomas I would like to help there, but I guess someone has to make all these repos... | 
| I think ss soon as the 3.4 is released, we will create all those repos. | 
| @roland-d this one got 2 good test :) | 
| Moving to RTC, 2 successful tests. | 
Executive summary
This PR converts the form validation on com_messages to use plain jquery (no mootools call on every form