Skip to content

Conversation

@dgrammatiko
Copy link
Contributor

Executive summary

This PR converts the form validation on com_modules to use plain jquery (no mootools call on every form).
Also NO MORE INLINE SCRIPTS!

Testing

  1. Apply first PR Reduce unneeded calls for mootools #4888 (!important)
  2. Apply this PR
  3. In the admin area go to com_modules and try to submit any form.

If no javascript errors are logged in your browser and the functionality remains the same your test is a pass in any other case please report the errors here

Please also check these:
administrator/index.php?option=com_checkin should demonstrate multiselect without mt
administrator/index.php?option=com_users&view=mail should demonstrate form sent and validate without mt
administrator/index.php?option=com_modules should demonstrate multiselect and combobox without mt
http://localhost/administrator/index.php?option=com_admin&view=sysinfo should demonstrate highlighter.js without mt
Logout and log in to demonstrate the use of noframes without mt.

@smanzi
Copy link

smanzi commented Nov 11, 2014

@DGT41 Conflicts with #4661
Tested without #4661: @test success

@anibalsanchez
Copy link
Contributor

@test success, only applied #4888 and #5049

@roland-d
Copy link
Contributor

Moving to RTC as we have 2 successful tests.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5049.

@brianteeman brianteeman added the RTC This Pull Request is Ready To Commit label Nov 29, 2014
@smanzi
Copy link

smanzi commented Nov 30, 2014

@test success for this PR
Tested the set of: #5046 #5048 #5049 #5050 #5051 #5052 #5053 #5054 #5056 #5058 #5113 #5255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants