javascript errordocument.id(‘something’); is failing

[smanzi]

The "Clear" button ("X") for several "Search" fields (e.g.: "Plugin Manager" and "Extensions Manager") is not functioning.

[dgrammatiko]

There is already a proposed PR: #4895 Apply that patch and functionality will be restored.

This is due to #4888 and the absence of #4895. In #4888 we removed mootools calls from the toolbar buttons. The links that are failing in many pages are the result of the absence of mootools. Admin area was always dependent on mootools but this, shouldn’t be the case for 3rd party components.
What is failing here is that the buttons or links are using document.id(‘something’); and instead should be using vanilla javascript:

There was another report for this but I guess it shouldn’t be closed. #5169
Sergio can you change the title here to something like: javascript errordocument.id(‘something’); is failing?
Thanks

[smanzi]

Confirmed! Applying #4895 does solve this issue!
Jumping to give an @test for #4895... This MUST be merged! 😄
Should I close this or leave it as a reminder?

[smanzi]

No need of an @test: it is already RTC, but it seems to lack the milestone...

[dgrammatiko]

Better leave it but can you change the title to something more generic as I proposed in the previous post?
I suspect if you close this I will have to write an answer again 😄

[smanzi]

@DGT41 Done: changed the title!

[dgrammatiko]

👍

[smanzi]

@DGT41 ... but this is not reflected in Jssues... 😞

[mbabker]

Unfortunately edits don't get synced across right away because GitHub's API doesn't send out data anymore when that happens. We have some cron jobs that should be taking care of this.

[dgrammatiko]

@infograf768 you can close this one, since #4895 is merged. Thanks