[6.0] Introduce Joomla 6.0 compatibility plugin

[HLeithner]

In the today's maintainer meeting we came to the conclusion that making a new plugin with a new name makes it easier
for us to update and maintain in the future.

Considerations:

• We need to activate the b/c plugin before upgrading 5.4 to 6.0 (it's not possible in the upgrade process)
• We would like to force the user to disable the b/c plugin in 5.4 before upgrading (if it site crashes in 5.4 it could be easily recovered by reactivating the plugin, but if it crashes after uninstall in the 6.0 upgrade process there is no way back)
• Both checks can be done in the pre update checker but only if we have 2 separated plugins

Summary of Changes

• Create the compat6 plugin
• Removed the compat plugin
• Moved already merged changes from old to compat6 plugin
• Removed all b/c functionally for 5 with the old compat plugin as discussed in the maintainers meeting from February

Testing Instructions

• New install and test with and without extensions
• Update from the latest 5.4 nightly build to the patched package or custom update URL created by Drone for this PR, having an extension installed on the 5.4 which will require the compat6 plugin to be enabled on Joomla 6.

Actual result BEFORE applying this Pull Request

Everything works without the old b/c plugin

After updating from 5.4, the old b/c plugin is still there.

Expected result AFTER applying this Pull Request

Everything works with the new b/c plugin

After updating from 5.4, the old b/c plugin is removed.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[richard67]

@HLeithner You also have to change the extensions helper from "compat" to "compat6" here: https://github.com/joomla/joomla-cms/blob/6.0-dev/libraries/src/Extension/ExtensionHelper.php#L176

[richard67]

Upgrade testing needs a separate PR which installs the extension in 5.4, so can't be tested yet ( @richard67 when done please update this section)

@HLeithner PR for 5.4 is #45371 . Question:

I did my PR in the same way as PR PR #41738 did it on 4.4 for the 5 plugin. That means the plugin does not have any configuration parameters set in the database.

That would not be a problem when the default values which the 6 plugin uses when reading its configuration are always so that all functionality is enabled.

Is this the case?

If not: Shall I add the right configuration parameters in the database to my PR?

But this would mean we have to maintain them there and in 6.0-dev here when we add some new ones.

[HLeithner]

by default, all parameters will be active in the code, so no parameters in the sql config is needed.

thanks for the PR

[richard67]

@HLeithner Is the file name of file "plugins/behaviour/compat6/src/Extension/Compat.php" right? Or shouldn't it be "Compat6.php"

Update: I've just tested with my PR, and yes, the file name has to fit to the class name, so it has to be "Compat6.php".

[richard67]

@HLeithner Is the file name of file "plugins/behaviour/compat6/src/Extension/Compat.php" right? Or shouldn't it be "Compat6.php"

Update: I've just tested with my PR, and yes, the file name has to fit to the class name, so it has to be "Compat6.php".

@HLeithner I've allowed myself to rename the file in your PR.

[HLeithner]

thanks

[heelc29]

UPDATE: Please DISable the new compat6 plugin during installation in system-tests (#45414).

[richard67]

Please enable the new compat6 plugin during installation in system-tests (#45414).

@heelc29 Sure you want to enable it? The PR you refer to disables the J5 plugin. In this PR here that should be changed to disable the new J6 plugin.

[heelc29]

Please enable the new compat6 plugin during installation in system-tests (#45414).

@heelc29 Sure you want to enable it? The PR you refer to disables the J5 plugin. In this PR here that should be changed to disable the new J6 plugin.

Sorry I mean DISABLE ;)

[richard67]

Please enable the new compat6 plugin during installation in system-tests (#45414).

@heelc29 Sure you want to enable it? The PR you refer to disables the J5 plugin. In this PR here that should be changed to disable the new J6 plugin.

Sorry I mean DISABLE ;)

@heelc29 We will handle that after the upmerge when we update this PR to the upmerged changes in the base branch and solve the conflicts.

[laoneo]

Suggested change

	if ($this->params->get('classes_aliases', '1')) {
	if ($this->params->get('classes_aliases')) {

[laoneo]

Suggested change

	default="1"
	default="0"

[HLeithner]

I keep them active for now and wait till we have a maintainer decision and what gets added to the list.

[laoneo]

There is a decission, check the last meeting report.

[richard67]

@HLeithner Now as @laoneo 's PR #44925 has been merged, this PR here has conflicts which can't be solved on GitHub. I think you know how to solve them. If not, let me know.