Skip to content

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Oct 12, 2024

Summary of Changes

This PR moves the CMS Filesystem classes to the compat plugin, allowing legacy third party code to still run when the plugin is active, but making the first step to finally remove it from the CMS.

I've added the Composer Dependency Changed label because the PR requires composer i to be run.

Testing Instructions

Copy the following line in a view of your choice to generate a call to the legacy classes:

var_dump(\Joomla\CMS\Filesystem\Folder::listFolderTree(JPATH_BASE, '.'));

Make sure the compat plugin is enabled AND you have to run composer i to generate an updated class loader file
Visit the view you edited in the browser to see an output of the call to the legacy class. Disable the plugin and see an error thrown instead.

Link to documentations

Please select:

@laoneo
Copy link
Member

laoneo commented Oct 14, 2024

Please move the "classes" folder outside of the src folder. Like it is now you have the src folder managed by a classloader and then the "classes" folder managed by another classloader. I would also rename the "classes" folder to legacy or so.

@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Oct 14, 2024
@Hackwar
Copy link
Member Author

Hackwar commented Oct 14, 2024

Done

@Bodge-IT
Copy link
Contributor

Thanks for all the work on these @Hackwar, can you resolve this little conflict? Then we can merge.

@Bodge-IT
Copy link
Contributor

Bodge-IT commented Mar 3, 2025

I have tested this item ✅ successfully on f7007b8

Good test after full wipe.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44240.

@softforge
Copy link
Contributor

Tested that the folder did not exist and then it all worked. Better testing instructions please


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44240.

@softforge
Copy link
Contributor

I have tested this item ✅ successfully on f7007b8

When I worked out what was actually needed... it worked


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44240.

@Bodge-IT Bodge-IT added the RTC This Pull Request is Ready To Commit label Mar 3, 2025
@Bodge-IT Bodge-IT merged commit 45c1e37 into joomla:6.0-dev Mar 3, 2025
4 of 5 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 3, 2025
@QuyTon QuyTon added this to the Joomla! 6.0.0 milestone Mar 3, 2025
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 4, 2025
@Hackwar Hackwar deleted the 6.0-filesystem2 branch March 4, 2025 10:31
Bodge-IT added a commit that referenced this pull request Mar 19, 2025
* Add deleted files and folders 2025-02-28

- New 5.x update SQL scripts
- Deleted files and folder from PR #43907 minus the file added back with PR #45015

* Add deleted files from PR #45021

* Add deleted files and folders from PRs #44240 and #45020

* Add new 5.3 update SQL scripts to deleted files

---------

Co-authored-by: Gary Barclay <[email protected]>
HLeithner added a commit to HLeithner/joomla-cms that referenced this pull request Apr 16, 2025
HLeithner added a commit that referenced this pull request May 14, 2025
* Create backward compatibility 6 plugin
* Moved relevant code from old compat plugin and removed it

considered changes from prs:
#44926
#44240
#44638
#44700
#43209
#43958
#42884

* Add new plugin on install and uninstall old plugin
* Remove compat media folder, add compat6 removed.asset.json
* Fix cs exceptions
* Update ExtensionHelper
* Rename Compat.php to Compat6.php
* Disable compat6 plugin for system tests
* Restore class aliases from compat 5 plugin
* Relocate files from #44925

---------

Co-authored-by: Richard Fath <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
softforge pushed a commit that referenced this pull request May 25, 2025
* Create backward compatibility 6 plugin

* Moved relevant code from old compat plugin and removed it

considered changes from prs:
#44926
#44240
#44638
#44700
#43209
#43958
#42884

* Add new plugin on install and uninstall old plugin

* Remove compat media folder, add compat6 removed.asset.json

* Fix cs exceptions

* Update ExtensionHelper

* Rename Compat.php to Compat6.php

* Disable compat6 plugin for system tests

* Update administrator/language/en-GB/plg_behaviour_compat6.ini

Co-authored-by: Brian Teeman <[email protected]>

* Update plugins/behaviour/compat6/compat6.xml

Co-authored-by: Brian Teeman <[email protected]>

* Update plugins/behaviour/compat6/compat6.xml

Co-authored-by: Brian Teeman <[email protected]>

* Update administrator/language/en-GB/plg_behaviour_compat6.ini

Co-authored-by: Brian Teeman <[email protected]>

* Update administrator/language/en-GB/plg_behaviour_compat6.sys.ini

Co-authored-by: Brian Teeman <[email protected]>

* Update plugins/behaviour/compat6/src/Extension/Compat6.php

* Restore class aliases from compat 5 plugin

* Relocate files from #44925

* Apply language string improvement from review suggestion

Co-authored-by: Brian Teeman <[email protected]>

* Update plugins/behaviour/compat6/src/Extension/Compat6.php

Co-authored-by: Allon Moritz <[email protected]>

* Update plugins/behaviour/compat6/compat6.xml

Co-authored-by: Allon Moritz <[email protected]>

* Update installation/sql/mysql/base.sql

Co-authored-by: Richard Fath <[email protected]>

* Update installation/sql/postgresql/base.sql

Co-authored-by: Richard Fath <[email protected]>

* Fix wrong folder in uninstallation of compat (5) plugin.

---------

Co-authored-by: Richard Fath <[email protected]>
Co-authored-by: Richard Fath <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
Co-authored-by: Benjamin Trenkle <[email protected]>
Co-authored-by: Allon Moritz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants