-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[6.0] Move CMS Filesystem package to compat plugin #44240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please move the "classes" folder outside of the src folder. Like it is now you have the src folder managed by a classloader and then the "classes" folder managed by another classloader. I would also rename the "classes" folder to legacy or so. |
e776cd0 to
770e5d1
Compare
|
Done |
Co-authored-by: jsanders <[email protected]>
|
Thanks for all the work on these @Hackwar, can you resolve this little conflict? Then we can merge. |
|
I have tested this item ✅ successfully on f7007b8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44240. |
|
Tested that the folder did not exist and then it all worked. Better testing instructions please This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44240. |
|
I have tested this item ✅ successfully on f7007b8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44240. |
* Add deleted files and folders 2025-02-28 - New 5.x update SQL scripts - Deleted files and folder from PR #43907 minus the file added back with PR #45015 * Add deleted files from PR #45021 * Add deleted files and folders from PRs #44240 and #45020 * Add new 5.3 update SQL scripts to deleted files --------- Co-authored-by: Gary Barclay <[email protected]>
considered changes from prs: joomla#44926 joomla#44240 joomla#44638 joomla#44700 joomla#43209 joomla#43958 joomla#42884
* Create backward compatibility 6 plugin * Moved relevant code from old compat plugin and removed it considered changes from prs: #44926 #44240 #44638 #44700 #43209 #43958 #42884 * Add new plugin on install and uninstall old plugin * Remove compat media folder, add compat6 removed.asset.json * Fix cs exceptions * Update ExtensionHelper * Rename Compat.php to Compat6.php * Disable compat6 plugin for system tests * Restore class aliases from compat 5 plugin * Relocate files from #44925 --------- Co-authored-by: Richard Fath <[email protected]> Co-authored-by: Brian Teeman <[email protected]>
* Create backward compatibility 6 plugin * Moved relevant code from old compat plugin and removed it considered changes from prs: #44926 #44240 #44638 #44700 #43209 #43958 #42884 * Add new plugin on install and uninstall old plugin * Remove compat media folder, add compat6 removed.asset.json * Fix cs exceptions * Update ExtensionHelper * Rename Compat.php to Compat6.php * Disable compat6 plugin for system tests * Update administrator/language/en-GB/plg_behaviour_compat6.ini Co-authored-by: Brian Teeman <[email protected]> * Update plugins/behaviour/compat6/compat6.xml Co-authored-by: Brian Teeman <[email protected]> * Update plugins/behaviour/compat6/compat6.xml Co-authored-by: Brian Teeman <[email protected]> * Update administrator/language/en-GB/plg_behaviour_compat6.ini Co-authored-by: Brian Teeman <[email protected]> * Update administrator/language/en-GB/plg_behaviour_compat6.sys.ini Co-authored-by: Brian Teeman <[email protected]> * Update plugins/behaviour/compat6/src/Extension/Compat6.php * Restore class aliases from compat 5 plugin * Relocate files from #44925 * Apply language string improvement from review suggestion Co-authored-by: Brian Teeman <[email protected]> * Update plugins/behaviour/compat6/src/Extension/Compat6.php Co-authored-by: Allon Moritz <[email protected]> * Update plugins/behaviour/compat6/compat6.xml Co-authored-by: Allon Moritz <[email protected]> * Update installation/sql/mysql/base.sql Co-authored-by: Richard Fath <[email protected]> * Update installation/sql/postgresql/base.sql Co-authored-by: Richard Fath <[email protected]> * Fix wrong folder in uninstallation of compat (5) plugin. --------- Co-authored-by: Richard Fath <[email protected]> Co-authored-by: Richard Fath <[email protected]> Co-authored-by: Brian Teeman <[email protected]> Co-authored-by: Benjamin Trenkle <[email protected]> Co-authored-by: Allon Moritz <[email protected]>
Summary of Changes
This PR moves the CMS Filesystem classes to the compat plugin, allowing legacy third party code to still run when the plugin is active, but making the first step to finally remove it from the CMS.
I've added the
Composer Dependency Changedlabel because the PR requirescomposer ito be run.Testing Instructions
Copy the following line in a view of your choice to generate a call to the legacy classes:
Make sure the compat plugin is enabled AND you have to run
composer ito generate an updated class loader fileVisit the view you edited in the browser to see an output of the call to the legacy class. Disable the plugin and see an error thrown instead.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Adding move of CMS filesystem package to compat plugin Manual#376
No documentation changes for manual.joomla.org needed