-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[6.0] Add removed Input classes to the compat plugin #44925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Why do we have to add back in all those classes, when most of it is a pretty much direct copy of the framework classes? Why can't we use the alias method? I mean, if you insist on adding back in old classes, I can understand to add the CLI class, but the rest is basically just duplicated code. I don't see why we need that. |
|
I leave the decision up to the RM's. |
|
For the record this one is tricker. Removing the alias from CMSInput functionally changes behavior and forces extensions to change much more of their code as a result. In this very specific case because of that I’m personally against merging this (for the record in favour of merging the other application one) |
|
I do mean that one and even though it's not in production it leads to a much bigger b/c break when the compat plugin is disabled. |
|
getting this error The file marked for modification does not exist: plugins/behaviour/compat/src/classmap/classmap.php This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44925. |
|
I have tested this item 🔴 unsuccessfully on 88f0ecd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44925. |
|
@tekvishal you need to test it with the code from version 6. This error has nothing to do with the current pr. Best is to use the prebuilt package. |
|
An additional comment to @wilsonge comment about the impact. The alias is only loaded when the compat plugin is enabled anyway, so this here is no difference to the state before as both ways are only loaded when the compat plugin is enabled. |
|
I have tested this item 🔴 unsuccessfully on 59330d8 See attachment below... This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44925. Screen.Recording.8.Mar.2025.at.1_32_36.AM-3.mp4 |
|
Thanks for the test, I'v updated the testing instructions with another class as we have an alias for the default input class. |
|
I have tested this item ✅ successfully on 59330d8 FYI, for the next testers, the error will show: An error has occurred. not A Class "Joomla\CMS\Input\Input" not found exception is thrown. as mentioned in the Testing instructions. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44925. |
|
@exlemor you are awesome! |
|
I have tested this item ✅ successfully on 59330d8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44925. |
|
RTC as it has 2 successful tests. But I will also add the RMDQ (release managers decision queue) label so it will be decided in the CMS Maintenance Team. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44925. |
|
Thanks for this @laoneo and for the testers @krishnaGandhi11 & @exlemor |
* Create backward compatibility 6 plugin * Moved relevant code from old compat plugin and removed it considered changes from prs: #44926 #44240 #44638 #44700 #43209 #43958 #42884 * Add new plugin on install and uninstall old plugin * Remove compat media folder, add compat6 removed.asset.json * Fix cs exceptions * Update ExtensionHelper * Rename Compat.php to Compat6.php * Disable compat6 plugin for system tests * Restore class aliases from compat 5 plugin * Relocate files from #44925 --------- Co-authored-by: Richard Fath <[email protected]> Co-authored-by: Brian Teeman <[email protected]>
* Create backward compatibility 6 plugin * Moved relevant code from old compat plugin and removed it considered changes from prs: #44926 #44240 #44638 #44700 #43209 #43958 #42884 * Add new plugin on install and uninstall old plugin * Remove compat media folder, add compat6 removed.asset.json * Fix cs exceptions * Update ExtensionHelper * Rename Compat.php to Compat6.php * Disable compat6 plugin for system tests * Update administrator/language/en-GB/plg_behaviour_compat6.ini Co-authored-by: Brian Teeman <[email protected]> * Update plugins/behaviour/compat6/compat6.xml Co-authored-by: Brian Teeman <[email protected]> * Update plugins/behaviour/compat6/compat6.xml Co-authored-by: Brian Teeman <[email protected]> * Update administrator/language/en-GB/plg_behaviour_compat6.ini Co-authored-by: Brian Teeman <[email protected]> * Update administrator/language/en-GB/plg_behaviour_compat6.sys.ini Co-authored-by: Brian Teeman <[email protected]> * Update plugins/behaviour/compat6/src/Extension/Compat6.php * Restore class aliases from compat 5 plugin * Relocate files from #44925 * Apply language string improvement from review suggestion Co-authored-by: Brian Teeman <[email protected]> * Update plugins/behaviour/compat6/src/Extension/Compat6.php Co-authored-by: Allon Moritz <[email protected]> * Update plugins/behaviour/compat6/compat6.xml Co-authored-by: Allon Moritz <[email protected]> * Update installation/sql/mysql/base.sql Co-authored-by: Richard Fath <[email protected]> * Update installation/sql/postgresql/base.sql Co-authored-by: Richard Fath <[email protected]> * Fix wrong folder in uninstallation of compat (5) plugin. --------- Co-authored-by: Richard Fath <[email protected]> Co-authored-by: Richard Fath <[email protected]> Co-authored-by: Brian Teeman <[email protected]> Co-authored-by: Benjamin Trenkle <[email protected]> Co-authored-by: Allon Moritz <[email protected]>
Summary of Changes
Reverts #42890 and moves the classes to the compat plugin instead of easier transition. It uses the same logic as #44240 without the option.
Testing Instructions
new \Joomla\CMS\Input\Json();Actual result BEFORE applying this Pull Request
A
Class "Joomla\CMS\Input\Json" not foundexception is thrown.Expected result AFTER applying this Pull Request
The articles list is loaded.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Change input chapter to be moved Manual#389
No documentation changes for manual.joomla.org needed