Skip to content

[5.3] Refactoring from CMS Folder to framework Folder class#43958

Merged
laoneo merged 9 commits intojoomla:5.3-devfrom
Hackwar:5.2-filesystem-folder
Oct 5, 2024
Merged

[5.3] Refactoring from CMS Folder to framework Folder class#43958
laoneo merged 9 commits intojoomla:5.3-devfrom
Hackwar:5.2-filesystem-folder

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Aug 21, 2024

Summary of Changes

What the title says. Right now this is still a draft.

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Fedik

This comment was marked as outdated.

@Hackwar
Copy link
Member Author

Hackwar commented Aug 29, 2024

As much as I'd like to see this in 5.2, I'm going to move this to 5.3. There just isn't enough time right now.

@Hackwar Hackwar changed the base branch from 5.2-dev to 5.3-dev August 29, 2024 16:02
@Hackwar Hackwar changed the title [5.2] Refactoring from CMS Folder to framework Folder class [5.3] Refactoring from CMS Folder to framework Folder class Aug 29, 2024
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev labels Aug 29, 2024
@Hackwar Hackwar removed the PR-5.2-dev label Sep 3, 2024
@joomla-cms-bot joomla-cms-bot removed Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester labels Sep 12, 2024
@Hackwar Hackwar marked this pull request as ready for review September 13, 2024 15:19
@Hackwar Hackwar requested a review from rdeutz as a code owner September 13, 2024 15:19
@rdeutz
Copy link
Contributor

rdeutz commented Sep 18, 2024

Looks good to me

@rdeutz rdeutz added the Maintainers Checked Used if the PR is conceptional useful label Sep 18, 2024
@laoneo laoneo self-assigned this Oct 4, 2024
@laoneo laoneo merged commit 29eb0b1 into joomla:5.3-dev Oct 5, 2024
@laoneo
Copy link
Member

laoneo commented Oct 5, 2024

Thanks!

@laoneo laoneo added this to the Joomla! 5.3.0 milestone Oct 5, 2024
@Hackwar Hackwar deleted the 5.2-filesystem-folder branch November 24, 2024 10:11
HLeithner added a commit to HLeithner/joomla-cms that referenced this pull request Apr 16, 2025
HLeithner added a commit that referenced this pull request May 14, 2025
* Create backward compatibility 6 plugin
* Moved relevant code from old compat plugin and removed it

considered changes from prs:
#44926
#44240
#44638
#44700
#43209
#43958
#42884

* Add new plugin on install and uninstall old plugin
* Remove compat media folder, add compat6 removed.asset.json
* Fix cs exceptions
* Update ExtensionHelper
* Rename Compat.php to Compat6.php
* Disable compat6 plugin for system tests
* Restore class aliases from compat 5 plugin
* Relocate files from #44925

---------

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Brian Teeman <brian@teeman.net>
softforge pushed a commit that referenced this pull request May 25, 2025
* Create backward compatibility 6 plugin

* Moved relevant code from old compat plugin and removed it

considered changes from prs:
#44926
#44240
#44638
#44700
#43209
#43958
#42884

* Add new plugin on install and uninstall old plugin

* Remove compat media folder, add compat6 removed.asset.json

* Fix cs exceptions

* Update ExtensionHelper

* Rename Compat.php to Compat6.php

* Disable compat6 plugin for system tests

* Update administrator/language/en-GB/plg_behaviour_compat6.ini

Co-authored-by: Brian Teeman <brian@teeman.net>

* Update plugins/behaviour/compat6/compat6.xml

Co-authored-by: Brian Teeman <brian@teeman.net>

* Update plugins/behaviour/compat6/compat6.xml

Co-authored-by: Brian Teeman <brian@teeman.net>

* Update administrator/language/en-GB/plg_behaviour_compat6.ini

Co-authored-by: Brian Teeman <brian@teeman.net>

* Update administrator/language/en-GB/plg_behaviour_compat6.sys.ini

Co-authored-by: Brian Teeman <brian@teeman.net>

* Update plugins/behaviour/compat6/src/Extension/Compat6.php

* Restore class aliases from compat 5 plugin

* Relocate files from #44925

* Apply language string improvement from review suggestion

Co-authored-by: Brian Teeman <brian@teeman.net>

* Update plugins/behaviour/compat6/src/Extension/Compat6.php

Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>

* Update plugins/behaviour/compat6/compat6.xml

Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>

* Update installation/sql/mysql/base.sql

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

* Update installation/sql/postgresql/base.sql

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

* Fix wrong folder in uninstallation of compat (5) plugin.

---------

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Richard Fath <richard.fath@t-online.de>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Benjamin Trenkle <bembelimen@users.noreply.github.com>
Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainers Checked Used if the PR is conceptional useful

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants