Skip to content

Conversation

@dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Feb 26, 2025

Pull Request for Issue # .

Summary of Changes

  • Removes the Web components polyfill
  • Cleanup the build tools

Testing Instructions

Try to edit an article, if the tabs are working then it's a successful test

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev labels Feb 26, 2025
@Fedik
Copy link
Member

Fedik commented Feb 26, 2025

Please create an empty wcpolyfill asset, and remove dependencies from core assets.
There are few:

"dependencies": [ "wcpolyfill" ]

@Fedik
Copy link
Member

Fedik commented Feb 26, 2025

Better add empty in to /build/media_source/plg_behaviour_compat/removed.asset.json.

@Fedik Fedik added the Removal Removes functionality label Feb 27, 2025
@Fedik
Copy link
Member

Fedik commented Feb 27, 2025

I have tested this item ✅ successfully on 9be209b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45019.

@laoneo laoneo added b/c break This item changes the behavior in an incompatible why. HEADS UP and removed Removal Removes functionality labels Feb 28, 2025
Copy link
Member

@HLeithner HLeithner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs b/c code after #45336 has been merged

@dgrammatiko
Copy link
Contributor Author

@softforge any interest here?

@dgrammatiko dgrammatiko force-pushed the 6.0-dev/remove-wc-polyfill branch from 0b1912c to 064b9ce Compare July 17, 2025 19:34
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 5c33cee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45019.

@Fedik
Copy link
Member

Fedik commented Aug 15, 2025

I have tested this item ✅ successfully on 1663aae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45019.

@Fedik Fedik dismissed HLeithner’s stale review August 15, 2025 16:30

The changes compat plugin was added

@Fedik
Copy link
Member

Fedik commented Aug 15, 2025

r2c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45019.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 15, 2025
@softforge softforge added this to the Joomla! 6.0.0 milestone Aug 16, 2025
@softforge softforge merged commit 7bd2c5b into joomla:6.0-dev Aug 16, 2025
30 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 16, 2025
@softforge
Copy link
Contributor

Thank you for the work on this, it made in before beta!

@dgrammatiko dgrammatiko deleted the 6.0-dev/remove-wc-polyfill branch August 16, 2025 12:56
@richard67
Copy link
Member

@dgrammatiko Can the media/vendor/webcomponentsjs folder be removed on update? Or do we have to keep it? Am asking because working on the deleted files and folders lists in script.php.

@dgrammatiko
Copy link
Contributor Author

Delete it!

@richard67
Copy link
Member

For deleting obsolete files and folders on update see #45928 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b/c break This item changes the behavior in an incompatible why. HEADS UP NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants