Skip to content

[5.4] Add compat6 behaviour plugin to 5.4 with enabled options#45525

Merged
muhme merged 1 commit intojoomla:5.4-devfrom
richard67:5.4-dev-compat-6-plugin-options
May 25, 2025
Merged

[5.4] Add compat6 behaviour plugin to 5.4 with enabled options#45525
muhme merged 1 commit intojoomla:5.4-devfrom
richard67:5.4-dev-compat-6-plugin-options

Conversation

@richard67
Copy link
Member

@richard67 richard67 commented May 24, 2025

Pull Request for Issue # .

Follow up to PR #45371 .

Summary of Changes

With pull request (PR) #45371 the backwards compatibility (b/c) plugin for Joomla 6 from PR #45336 has been added to the 5.4-dev branch so that the plugin is already available and active on Joomla 5.4 when we update to Joomla 6.

This PR here completes that by making sure that the plugins' options are enabled on update to Joomla 6 so we can be sure a 3rd party system or behaviour plugin which will require these options on Joomla 6 does not cause the update to fail.

As the update SQL scripts modified by this PR have not been released yet we safely can change them.

Testing Instructions

Code review is sufficient.

Check that the params values changed by this PR here fits to the corresponding values in PR #45480 .

See e.g. here: https://github.com/joomla/joomla-cms/pull/45480/files#diff-3a9a51c74db65d66b70dbd56c86e63882cfaa26701ef6ff3f88bd0ea2682bb9fR265

But if you want to do a real test:

1. New installation

Make a new installation of the latest 5.4-dev nightly build to get the actual result, and make a new installation with the patched package created by Drone for this PR to get the expected result.

Then check the params value of the plg_behaviour_compat6 plugin in the #__extensions table.

2. Update

Update a 5.3.x or a recent 5.3-dev nightly build to the latest 5.4-dev nightly build to get the actual result, and update a 5.3.x or a recent 5.3-dev nightly build to the patched package created by Drone for this PR to get the expected result.

Then check the params value of the plg_behaviour_compat6 plugin in the #__extensions table.

Actual result BEFORE applying this Pull Request

After a new installation or an update from 5.3 or older, the plugin is added with params='{}'.

Expected result AFTER applying this Pull Request

After a new installation or an update from 5.3 or older, the plugin is added with params='{"classes_aliases":"1","legacy_classes":"1"}'.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@bembelimen
Copy link
Contributor

I have tested this item ✅ successfully on 44e1327


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45525.

@LadySolveig
Copy link
Contributor

I have tested this item ✅ successfully on 44e1327

Code Review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45525.

@richard67
Copy link
Member Author

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45525.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 25, 2025
@muhme muhme merged commit d2198dc into joomla:5.4-dev May 25, 2025
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 25, 2025
@muhme
Copy link
Contributor

muhme commented May 25, 2025

thxs all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants