[5.4] Add compat6 behaviour plugin to 5.4 with enabled options#45525
Merged
muhme merged 1 commit intojoomla:5.4-devfrom May 25, 2025
Merged
[5.4] Add compat6 behaviour plugin to 5.4 with enabled options#45525muhme merged 1 commit intojoomla:5.4-devfrom
muhme merged 1 commit intojoomla:5.4-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 44e1327 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45525. |
LadySolveig
approved these changes
May 25, 2025
Contributor
|
I have tested this item ✅ successfully on 44e1327 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45525. |
Member
Author
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45525. |
Contributor
|
thxs all |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Follow up to PR #45371 .
Summary of Changes
With pull request (PR) #45371 the backwards compatibility (b/c) plugin for Joomla 6 from PR #45336 has been added to the 5.4-dev branch so that the plugin is already available and active on Joomla 5.4 when we update to Joomla 6.
This PR here completes that by making sure that the plugins' options are enabled on update to Joomla 6 so we can be sure a 3rd party system or behaviour plugin which will require these options on Joomla 6 does not cause the update to fail.
As the update SQL scripts modified by this PR have not been released yet we safely can change them.
Testing Instructions
Code review is sufficient.
Check that the
paramsvalues changed by this PR here fits to the corresponding values in PR #45480 .See e.g. here: https://github.com/joomla/joomla-cms/pull/45480/files#diff-3a9a51c74db65d66b70dbd56c86e63882cfaa26701ef6ff3f88bd0ea2682bb9fR265
But if you want to do a real test:
1. New installation
Make a new installation of the latest 5.4-dev nightly build to get the actual result, and make a new installation with the patched package created by Drone for this PR to get the expected result.
Then check the
paramsvalue of theplg_behaviour_compat6plugin in the#__extensionstable.2. Update
Update a 5.3.x or a recent 5.3-dev nightly build to the latest 5.4-dev nightly build to get the actual result, and update a 5.3.x or a recent 5.3-dev nightly build to the patched package created by Drone for this PR to get the expected result.
Then check the
paramsvalue of theplg_behaviour_compat6plugin in the#__extensionstable.Actual result BEFORE applying this Pull Request
After a new installation or an update from 5.3 or older, the plugin is added with
params='{}'.Expected result AFTER applying this Pull Request
After a new installation or an update from 5.3 or older, the plugin is added with
params='{"classes_aliases":"1","legacy_classes":"1"}'.Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed