[6.0] Gsoc2021 35228 merge featured

[chmst]

Pull Request for Issue # .
This Pull request rewrites the #35228 as meanwhile many changes were made.

The purpose of theis PR is to merge the "featured" articles into the articles classes and remove duplicate code from com_content
This PR changes only the backend, nothing in frontend.

Summary of Changes

See PR #35228
Additionally the quickicon "featured".

Testing Instructions

as described in #35228, plus a view on quickicons

If you test on an existing site, please do this as first step:

UPDATE #__menu
SET link = 'index.php?option=com_content&view=articles&filter[featured]=1'
WHERE link = 'index.php?option=com_content&view=featured'
AND client_id = 1;

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

See PR #35228

Link to documentations

Please select:

• Documentation link for docs.joomla.org: help doc and tbd

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org: tbd

• No documentation changes for manual.joomla.org needed

[richard67]

@chmst There are still code style issues, e.g. unused imports (use statements) to be removed. Unfortunately many of them are outside of what can be done with a code change suggestion on GitHub, so I can't help with suggestions here. See the log here: https://ci.joomla.org/joomla/joomla-cms/78000/1/7 . If necessary I can help tomorrow after work. Would be good to get the phpcs fixed so the system tests will be started in Drone.

[brianteeman]

• @deprecated 6.0 will be removed in 7.0

I thought the policy was deprecated in x and removed in x+2 ?

[richard67]

@chmst Does this PR replace PR #35228 ? If yes, shall we close the latter?

And could you check the conflicting files? I think the conflicts come from PRs #43323 and #43512 , but I don't have the time now to check in detail.

[richard67]

@chmst I've allowed myself to fix the conflicts. Please check the result.

[chmst]

With new changes, the filter goes back into the normal filter toolbar, so that user do not see a differnce against J5, we do not need make changes in user documentation.

At the moment we have one flaw - the featured link in the admin module ist not marked as active.

[obuisard]

Everything works flawlessly and I like this change. Great thanks Christiane @chmst.

I do have one comment, which is a behavior I have noticed:

• when you filter articles by a category, for instance 'blog', then go somewhere else, for instance in the 'fields' page and then you go back to the articles view, the filter 'blog' is still selected (and everything works that way for categories...).
• when you filter articles by category 'blog', then go to 'featured articles' view, the category 'blog' is no longer selected.

This is reproducing the behavior we had before this PR: when going to the 'featured articles' view, we had a featured articles view you could filter independently from the articles view. But now that the views are merged, we cannot have distinct filtering any longer.

I do think that for consistency with the other pages, we should retain filters while switching between 'articles' and 'featured articles' views.

[exlemor]

I have tested this again thoroughly and agree with Olivier, aside from the oddity he describes, it works but it would b great if that oddity was solved.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43907.}

[obuisard]

I have tested this item ✅ successfully on fab5f02

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43907.}

[laoneo]

Is this documented?

[softforge]

Hi, @chmst, Thank you for persisting and getting to this point.
Would you mind providing some documentation for the manual.joomla.org? I am sure Anja will be wanting to get an article about it for the magazine as well

[chmst]

I am happy that it is merged - thanks to all who helped with that. I am pretty sure that there will come some more issues.

@laoneo will do documentation in the manual for deprecations. There is no change in the views and users should not see any difference.

@softforge - will see what I can do

[ceford]

I made a new clone and checked out 6.0-dev so my Title bar is showing 6.0.0-beta3-dev. But the files that should have been deleted in this PR are still present. Is that normal?

[brianteeman]

@ceford this was merged into j6 six months ago

[ceford]

@ceford this was merged into j6 six months ago

The release leaders have asked a few of us to check documentation. So I am just reporting what appears to be an anomaly. It may be nothing to worry about.

[brianteeman]

My point is that the code is merged already so you only need to install the beta release to check the code against documentation