Skip to content

[6.0] Remove the tab state script #45021

Merged
softforge merged 1 commit intojoomla:6.0-devfrom
dgrammatiko:6.0-dev/tab-state
Feb 28, 2025
Merged

[6.0] Remove the tab state script #45021
softforge merged 1 commit intojoomla:6.0-devfrom
dgrammatiko:6.0-dev/tab-state

Conversation

@dgrammatiko
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

  • Remove the tab state script (not in use since 4.0)

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev labels Feb 26, 2025
@brianteeman
Copy link
Contributor

why?

@dgrammatiko
Copy link
Contributor Author

It’s not used anywhere since 4.0

@brianteeman
Copy link
Contributor

then it should be deprecated ie advance notice given that it will be removed

@dgrammatiko
Copy link
Contributor Author

It's already in the LEGACY folder, so by definition WAS deprecated

@brianteeman
Copy link
Contributor

we will have to agree to disagree then on that

@dgrammatiko
Copy link
Contributor Author

It's not the first time

@dgrammatiko
Copy link
Contributor Author

I mean we had this conversation 6 years ago: #26838

@Fedik
Copy link
Member

Fedik commented Feb 27, 2025

I have tested this item ✅ successfully on 2bb62a6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45021.

@Fedik Fedik added the Removal Removes functionality label Feb 27, 2025
@laoneo laoneo added b/c break This item changes the behavior in an incompatible why. HEADS UP and removed Removal Removes functionality labels Feb 28, 2025
@softforge softforge added RTC This Pull Request is Ready To Commit and removed RTC This Pull Request is Ready To Commit labels Feb 28, 2025
@exlemor
Copy link

exlemor commented Feb 28, 2025

I have tested this item ✅ successfully on 2bb62a6

I have tested this successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45021.

@softforge softforge merged commit a383988 into joomla:6.0-dev Feb 28, 2025
4 checks passed
@softforge softforge added this to the Joomla! 6.0.0 milestone Feb 28, 2025
@dgrammatiko
Copy link
Contributor Author

@softforge please also merge joomla/Manual#414

@dgrammatiko dgrammatiko deleted the 6.0-dev/tab-state branch February 28, 2025 16:26
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 1, 2025
Bodge-IT added a commit that referenced this pull request Mar 19, 2025
* Add deleted files and folders 2025-02-28

- New 5.x update SQL scripts
- Deleted files and folder from PR #43907 minus the file added back with PR #45015

* Add deleted files from PR #45021

* Add deleted files and folders from PRs #44240 and #45020

* Add new 5.3 update SQL scripts to deleted files

---------

Co-authored-by: Gary Barclay <1881642+Bodge-IT@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b/c break This item changes the behavior in an incompatible why. HEADS UP NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants