Skip to content

fix: python nested venv path order#6124

Merged
jdx merged 2 commits intojdx:mainfrom
elvismacak:fix/python-nested-venv-path-order
Sep 5, 2025
Merged

fix: python nested venv path order#6124
jdx merged 2 commits intojdx:mainfrom
elvismacak:fix/python-nested-venv-path-order

Conversation

@elvismacak
Copy link
Contributor

As discovered #4510 and https://github.com/jdx/mise/issues/4515 , the nested python venv path is incorrect.

I locate the code below, the code origin target is prepend reversed paths to r. env_paths, but the r. env_paths is already reversed outside.

@jdx
Copy link
Owner

jdx commented Aug 26, 2025

needs e2e test

@elvismacak elvismacak force-pushed the fix/python-nested-venv-path-order branch 6 times, most recently from 9cc00fc to d42bf1b Compare September 1, 2025 08:18
@elvismacak elvismacak force-pushed the fix/python-nested-venv-path-order branch from d42bf1b to 5ba4ee2 Compare September 1, 2025 08:32
@elvismacak elvismacak force-pushed the fix/python-nested-venv-path-order branch from 5ba4ee2 to 654548d Compare September 2, 2025 02:12
@jdx jdx merged commit fea2c39 into jdx:main Sep 5, 2025
17 checks passed
jdx pushed a commit that referenced this pull request Sep 5, 2025
### 🐛 Bug Fixes

- python nested venv path order by
[@elvismacak](https://github.com/elvismacak) in
[#6124](#6124)
- resolve immutable release workflow and VERSION file timing issues by
[@jdx](https://github.com/jdx) in
[#6187](#6187)

### New Contributors

- @elvismacak made their first contribution in
[#6124](#6124)
jdx added a commit that referenced this pull request Sep 5, 2025
…iff template (#6194)

## Summary
- Fixes the changelog formatting issue where the New Contributors
section was running into the next version header
- Adds a blank line after the contributor list to ensure proper
separation

## Problem
The previous fix (PR #6190) to remove extra blank lines inadvertently
caused a new issue. The `{% endfor -%}` directive was stripping the
trailing newline after the contributor list, causing the next version
header to appear on the same line as the last contributor.

Example of the issue in PR #6192:
https://github.com/jdx/mise/pull/6192/files

The formatting looked like:
```
- @elvismacak made their first contribution in [#6124]## [2025.9.0]...
```

## Solution
Changed the template from:
```jinja
{% endfor -%}
{% endif -%}
```

To:
```jinja
{% endfor %}

{% endif -%}
```

This adds a blank line after the contributor list while still stripping
the trailing newline after the endif block to avoid extra spacing after
the section.

## Test plan
- [ ] Generate changelog with `git cliff` and verify New Contributors
sections have proper spacing
- [ ] Verify no extra blank lines between commits within sections
- [ ] Check that version headers are properly separated from previous
sections

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Claude <noreply@anthropic.com>
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Sep 8, 2025
## [2025.9.5](https://github.com/jdx/mise/compare/v2025.9.4..v2025.9.5) - 2025-09-06

### 🚀 Features

- **(task)** add timeout support for task execution by @jdx in [#6216](jdx/mise#6216)
- **(task)** sub-tasks in run lists by @jdx in [#6212](jdx/mise#6212)

### Chore

- fix npm publish action by @jdx in [14f4b09](jdx/mise@14f4b09)
- fix cloudflare release action by @jdx in [00afa25](jdx/mise@00afa25)
- fix git-cliff for release notes by @jdx in [15a9aed](jdx/mise@15a9aed)

## [2025.9.4](https://github.com/jdx/mise/compare/v2025.9.3..v2025.9.4) - 2025-09-06

### Chore

- fix git-cliff on release by @jdx in [3c388f2](jdx/mise@3c388f2)

## [2025.9.3](https://github.com/jdx/mise/compare/v2025.9.2..v2025.9.3) - 2025-09-06

### 🚀 Features

- **(backend)** improve http error when platform url missing; list available platforms by @jdx in [#6200](jdx/mise#6200)
- **(cli)** support scoped packages for all backend types by @earlgray283 in [#6213](jdx/mise#6213)
- **(http)** add URL replacement feature for HTTP requests by @ThomasSteinbach in [#6207](jdx/mise#6207)

### 🐛 Bug Fixes

- **(backend)** preserve arch underscores in platform keys by @jdx in [#6202](jdx/mise#6202)
- **(task)** resolve hanging issue with multiple depends_post by @jdx in [#6206](jdx/mise#6206)
- couldn't download node binary in Alpine, even if it exists in the mirror url by @Hazer in [#5972](jdx/mise#5972)
- **breaking** use config_root for env._.path by @jdx in [#6204](jdx/mise#6204)
- bugfix for paths that include spaces by @karim-elkholy in [#6210](jdx/mise#6210)

### 📚 Documentation

- improve release notes generation by @jdx in [#6197](jdx/mise#6197)
- fix release changelog contributor reporting by @jdx in [#6201](jdx/mise#6201)

### Chore

- use fine-grained gh token by @jdx in [#6208](jdx/mise#6208)
- use settings.local.json for claude config by @jdx in [fd0fba9](jdx/mise@fd0fba9)

### New Contributors

- @ThomasSteinbach made their first contribution in [#6207](jdx/mise#6207)
- @earlgray283 made their first contribution in [#6213](jdx/mise#6213)
- @karim-elkholy made their first contribution in [#6210](jdx/mise#6210)
- @Hazer made their first contribution in [#5972](jdx/mise#5972)

## [2025.9.2](https://github.com/jdx/mise/compare/v2025.9.1..v2025.9.2) - 2025-09-05

### 🐛 Bug Fixes

- **(ci)** set required environment variables for npm publishing by @jdx in [#6189](jdx/mise#6189)
- **(release)** clean up extra newlines in release notes formatting by @jdx in [#6190](jdx/mise#6190)
- **(release)** add proper newline after New Contributors section in cliff template by @jdx in [#6194](jdx/mise#6194)
- **(release)** fix changelog formatting to remove extra blank lines by @jdx in [#6195](jdx/mise#6195)
- **(release)** restore proper newline after New Contributors section by @jdx in [#6196](jdx/mise#6196)

### 🚜 Refactor

- **(ci)** split release workflow into separate specialized workflows by @jdx in [#6193](jdx/mise#6193)

### Chore

- **(release)** require GitHub Actions environment for release-plz script by @jdx in [#6191](jdx/mise#6191)

## [2025.9.1](https://github.com/jdx/mise/compare/v2025.9.0..v2025.9.1) - 2025-09-05

### 🐛 Bug Fixes

- python nested venv path order by @elvismacak in [#6124](jdx/mise#6124)
- resolve immutable release workflow and VERSION file timing issues by @jdx in [#6187](jdx/mise#6187)

### New Contributors

- @elvismacak made their first contribution in [#6124](jdx/mise#6124)

## [2025.9.0](https://github.com/jdx/mise/compare/v2025.8.21..v2025.9.0) - 2025-09-05

### 🚀 Features

- allow set/unset backend aliases by @roele in [#6172](jdx/mise#6172)

### 🐛 Bug Fixes

- **(aqua)** respect order of asset_strs by @risu729 in [#6143](jdx/mise#6143)
- **(java)** treat freebsd as linux (assuming linux compatability) by @roele in [#6161](jdx/mise#6161)
- **(nushell/windows)** Fix $env.PATH getting converted to a string by @zackyancey in [#6157](jdx/mise#6157)
- **(sync)** create uv_versions_path dir if it doesn't exist by @risu729 in [#6142](jdx/mise#6142)
- **(ubi)** show relevent error messages for v-prefixed tags by @risu729 in [#6183](jdx/mise#6183)
- remove nodejs/golang alias migrate code by @risu729 in [#6141](jdx/mise#6141)
- mise activate not working on powershell v5 by @L0RD-ZER0 in [#6168](jdx/mise#6168)

### 📚 Documentation

- **(task)** remove word "additional" to avoid confusions by @risu729 in [#6159](jdx/mise#6159)

### Chore

- update Cargo.lock by @risu729 in [#6184](jdx/mise#6184)

### New Contributors

- @zackyancey made their first contribution in [#6157](jdx/mise#6157)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants