fix: couldn't download node binary in Alpine, even if it exists in the mirror url

[Hazer]

I was trying to use in Alpine the following build:

https://unofficial-builds.nodejs.org/download/release/v24.5.0/node-v24.5.0-linux-x64-musl.tar.gz

So I set:

export MISE_NODE_MIRROR_URL=https://unofficial-builds.nodejs.org/download/release/
export MISE_NODE_FLAVOR=musl
export MISE_NODE_COMPILE=false

# and/or

mise settings set node.mirror_url https://unofficial-builds.nodejs.org/download/release/
mise settings set node.flavor musl
mise settings set node.compile 0

But mise install would always fail trying to download https://unofficial-builds.nodejs.org/download/release/v24.5.0/node-v24.5.0.tar.gz that don't exist.

The main issue was that my settings.node.compile false was being overridden by the distro all_compile override, and it would then try to download the source code for compilation, and fail, took me a long while to figure that out. The real fix was just avoiding the all_compile override if node.compile was set by the user manually. Added a info log to avoid future issues with not understand where this behavior came from.

The rest of the changes in plugins/core/node.rs are not necessary to solve the bug, but I would like to try pushing too:

• I made a fetch_binary to reuse/deduplicate code for posix and windows, while at it made the logic about Ok explicit and about the NotFound case too; (while the diff looks horrible, imho the final code is clearer to reason and safer now, for someone new to the codebase)
• it now makes explicitly clear when "precompiled node archive not found and compilation is disabled" happens.
• Renamed install_compiled to install_compiling to make the intent of the method really clear, the first time I read the code I was confusing install_compiled and install_precompiled
• Made the unarchiving logic reusable, I was thinking in moving to another place to let other packages use something like this, but it's just that for now;
• Made sure the errors where not encapsulated by using Report::from (I had a bug because of it while testing stuff that shouldn't ever happen, making an Ok(()) be tested and treated as 404 somehow, but the previous flow allowed it when I made my broken test changes, so this could eventually cause a bug to some bad change in the future) removed by autofix
• Added 2 info logs that would've been crucial to understand this issue.
• Added more debug logging around the areas that eventually led me to discover the issue, and areas I was under the impression could be potential troublemakers.

The new install_precompiled and install_windows method bodies here for faster reading than the diff, just to try to defend my "unnecessary" changes easier 😆:

   async fn install_precompiled(
       &self,
       ctx: &InstallContext,
       tv: &mut ToolVersion,
       opts: &BuildOpts,
   ) -> Result<()> {
       match self
           .fetch_binary(ctx, tv, opts, || {
               self.extract_tarball(
                   &opts.binary_tarball_path,
                   &opts.install_path,
                   ctx,
                   1, // strip_components for binary tarball
               )
           })
           .await?
       {
           FetchOutcome::Downloaded => Ok(()),
           FetchOutcome::NotFound => {
               if Settings::get().node.compile != Some(false) {
                   self.install_compiling(ctx, tv, opts).await
               } else {
                   bail!("precompiled node archive not found and compilation is disabled")
               }
           }
       }
   }

   async fn install_windows(
       &self,
       ctx: &InstallContext,
       tv: &mut ToolVersion,
       opts: &BuildOpts,
   ) -> Result<()> {
       match self
           .fetch_binary(ctx, tv, opts, || self.extract_zip(opts, ctx))
           .await?
       {
           FetchOutcome::Downloaded => Ok(()),
           FetchOutcome::NotFound => bail!("precompiled node archive not found (404)"),
       }
   }

[jdx]

bugbot run

[jdx]

bugbot run

[cursor]

Bug: Missing Cleanup in Precompiled Install Path

The install_precompiled path is missing the file::remove_all(&opts.install_path) call that previously cleared the install directory before extraction. This omission can lead to stale files or installation failures when installing over an existing version. Other installation paths, like Windows or compiling from source, still include this cleanup.