Skip to content

fix: python nested venv path order #6124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 2 commits into from
Sep 5, 2025
Merged

fix: python nested venv path order #6124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f09a7b3
fix: python nested venv path order
elvismacak Aug 26, 2025
654548d
add e2e test
elvismacak Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions e2e/env/test_env_path
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,14 @@ _.path = ['a', 'b']
EOF
assert "mise dr path" "$PWD/a
$PWD/b"

mkdir -p sub_dir
cd sub_dir
cat <<'EOF' >mise.toml
[env]
_.path = ['c', 'd']
EOF
assert "mise dr path" "$PWD/c
$PWD/d
${PWD%/*}/a
${PWD%/*}/b"
9 changes: 5 additions & 4 deletions src/config/env_directive/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,17 +366,18 @@ impl EnvResults {
.or_else(|| dirs::CWD.clone())
.unwrap_or_default();
let paths = paths.map(|(p, _)| p).collect_vec();
let paths = paths
let mut paths = paths
.iter()
.rev()
.flat_map(|path| env::split_paths(path))
.map(|s| normalize_path(&config_root, s))
.collect::<Vec<_>>();
r.env_paths.extend(paths);
// r.env_paths is already reversed and paths should prepend r.env_paths
paths.reverse();
paths.extend(r.env_paths);
r.env_paths = paths;
}

r.env_paths.reverse();

Ok(r)
}

Expand Down
Loading