Conversation
mise-en-dev
force-pushed
the
release
branch
2 times, most recently
from
db5f3b0 to
2f95b72
Compare
3 tasks
jdx
added a commit
that referenced
this pull request
Sep 5, 2025
…iff template (#6194) ## Summary - Fixes the changelog formatting issue where the New Contributors section was running into the next version header - Adds a blank line after the contributor list to ensure proper separation ## Problem The previous fix (PR #6190) to remove extra blank lines inadvertently caused a new issue. The `{% endfor -%}` directive was stripping the trailing newline after the contributor list, causing the next version header to appear on the same line as the last contributor. Example of the issue in PR #6192: https://github.com/jdx/mise/pull/6192/files The formatting looked like: ``` - @elvismacak made their first contribution in [#6124]## [2025.9.0]... ``` ## Solution Changed the template from: ```jinja {% endfor -%} {% endif -%} ``` To: ```jinja {% endfor %} {% endif -%} ``` This adds a blank line after the contributor list while still stripping the trailing newline after the endif block to avoid extra spacing after the section. ## Test plan - [ ] Generate changelog with `git cliff` and verify New Contributors sections have proper spacing - [ ] Verify no extra blank lines between commits within sections - [ ] Check that version headers are properly separated from previous sections 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <noreply@anthropic.com>
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.9.1 x -- echo |
18.8 ± 6.0 | 17.9 | 151.6 | 1.00 ± 0.32 |
mise x -- echo |
18.8 ± 0.3 | 18.1 | 20.1 | 1.00 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.9.1 env |
17.9 ± 0.2 | 17.5 | 19.6 | 1.00 |
mise env |
18.1 ± 0.6 | 17.6 | 26.1 | 1.01 ± 0.04 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.9.1 hook-env |
17.6 ± 0.3 | 17.2 | 20.6 | 1.00 |
mise hook-env |
17.7 ± 0.2 | 17.2 | 18.5 | 1.00 ± 0.02 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.9.1 ls |
16.0 ± 0.2 | 15.5 | 16.8 | 1.00 |
mise ls |
16.0 ± 0.2 | 15.6 | 17.3 | 1.00 ± 0.02 |
xtasks/test/perf
| Command | mise-2025.9.1 | mise | Variance |
|---|---|---|---|
| install (cached) | 162ms | ✅ 101ms | +60% |
| ls (cached) | 61ms | 61ms | +0% |
| bin-paths (cached) | 64ms | 65ms | -1% |
| task-ls (cached) | 464ms | 463ms | +0% |
✅ Performance improvement: install cached is 60%
mise-en-dev
force-pushed
the
release
branch
2 times, most recently
from
9ad5fcf to
6b8c64d
Compare
4 tasks
jdx
added a commit
that referenced
this pull request
Sep 5, 2025
The previous fix removed too much whitespace. The New Contributors
section needs a blank line after it to properly separate from the next
version header.
Changes:
- Changed line 51 from `{% endif -%}` to `{% endif %}`
- This preserves the newline after the New Contributors section
This fixes the issue seen in PR #6192 where the New Contributors line
runs directly into the next version header.
Test with: `git cliff --strip all --tag v2025.9.1 v2025.9.0..v2025.9.1`
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
jdx
added a commit
that referenced
this pull request
Sep 5, 2025
…6196) ## Summary - Fixes the missing newline after the New Contributors section - Includes regenerated CHANGELOG.md to verify the fix works correctly ## Problem The previous fix (#6195) removed too much whitespace. While it correctly fixed the extra blank line between commits and the New Contributors section, it also removed the newline after the New Contributors section, causing it to run directly into the next version header. In PR #6192, you can see the problem where the New Contributors line runs directly into the next version: ``` - @elvismacak made their first contribution## [2025.9.0]... ``` ## Solution Changed line 51 in cliff.toml from `{% endif -%}` to `{% endif %}` to preserve the newline after the New Contributors section. ## Verification The CHANGELOG.md has been regenerated and included in this PR to verify the formatting is correct: - ✅ No extra blank lines between commits within sections - ✅ No extra blank lines before New Contributors heading - ✅ Proper blank line preserved after New Contributors section You can see in the included CHANGELOG.md that the formatting is now clean and consistent throughout. ## Test plan - [x] Generated CHANGELOG.md with `git cliff -o CHANGELOG.md` - [x] Verified New Contributors sections have proper spacing - [x] Checked that version headers are properly separated - [ ] Verify the next release generates properly formatted release notes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| ### New Contributors | ||
|
|
||
| - @jdx made their first contribution in [#6196](https://github.com/jdx/mise/pull/6196) |
There was a problem hiding this comment.
Bug: Changelog Misidentifies Maintainer as New Contributor
The changelog incorrectly lists @jdx in the 'New Contributors' section. Since @jdx is the project's main maintainer with numerous prior contributions, this points to an issue in the changelog generation logic, creating a misleading entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fixes
🚜 Refactor
Chore