fix: resolve immutable release workflow and VERSION file timing issues

[jdx]

Summary

This PR fixes two critical issues in the release process:

1. Immutable release error: GitHub releases cannot be modified once created, preventing asset uploads
2. VERSION file published too early: VERSION was published before release was finalized

Problems

1. Immutable Release Error

• GitHub releases cannot add assets after creation (even drafts)
• The workflow was trying to upload assets after release creation, causing failures
• Need to create release with all assets in a single atomic operation

2. VERSION File Timing

• VERSION file was created and published to R2/Cloudflare during release preparation
• If the GitHub release failed, VERSION was already out there pointing to a non-existent release
• This could break installations that depend on the VERSION file

Solution

Release Creation

• Create a draft release with all assets in a single gh release create --draft command
• This allows the release to be reviewed before making it public
• Assets are uploaded atomically with the release creation
• Publish the draft release as the final step after everything else succeeds

VERSION File Timing

• Split release.sh into preparation and publishing phases
• Created new publish-release.sh script that runs AFTER draft release is created
• Moved VERSION file creation and R2 publishing after draft release exists
• Separated npm, Cloudflare worker, and redirect into individual workflow steps for better visibility
• Only publish the GitHub release (make it public) after everything succeeds

New Release Flow

1. release-plz creates and pushes git tag with release notes
2. release.yml workflow triggers on tag push
3. Workflow builds all assets and prepares release artifacts
4. Draft GitHub release created with all assets in single atomic command
5. VERSION file created and published to R2
6. npm package published (@jdxcode/mise)
7. Cloudflare worker deployed
8. Redirect updated (allowed to fail)
9. Draft release is published (made public) as the final step

Benefits

• ✅ Release can be reviewed in draft state before publishing
• ✅ Assets are uploaded atomically with release creation (no immutability issues)
• ✅ VERSION file only exists for successfully created releases
• ✅ Each deployment step is isolated for better debugging and visibility
• ✅ Release is only made public after everything else succeeds
• ✅ If any step fails, the release remains in draft and can be manually fixed or deleted

Files Changed

• .github/workflows/release.yml - Create draft release atomically, separate deployment steps, publish as final step
• xtasks/release-plz - Remove GitHub release creation (only creates git tag)
• scripts/release.sh - Remove publishing logic (only prepares artifacts)
• scripts/publish-release.sh - New script for VERSION file and R2 publishing

Test plan

• Verify the release workflow runs successfully on next tag push
• Confirm draft GitHub release is created with all assets atomically
• Check VERSION file is created after draft release exists
• Verify npm publishing shows as separate step
• Verify Cloudflare worker deployment shows as separate step
• Verify redirect update shows as separate step (and can fail without blocking)
• Verify draft release is published only after all steps succeed
• Test failure scenario: if any step fails, release should remain in draft

Fixes: https://github.com/jdx/mise/actions/runs/17492019918/job/49686112317

🤖 Generated with Claude Code

[Copilot]

Pull Request Overview

This PR fixes a release workflow issue where GitHub releases were becoming immutable before assets could be uploaded. The solution restructures the release process to ensure a single, consistent workflow that creates draft releases for asset uploads before publishing.

• Removed duplicate GitHub release creation from the release-plz script
• Modified the main release workflow to create releases as drafts initially
• Added a step to publish the release after assets are uploaded

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
xtasks/release-plz	Removed GitHub release creation, leaving only git tag creation and push
.github/workflows/release.yml	Modified release creation to use draft state initially, then publish after asset upload

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The gh release edit command uses a shell command substitution that may not return the expected tag version. Consider using ${{github.ref_name}} instead of $(./scripts/get-version.sh) for consistency with the file upload step above, or ensure the script returns the correct tag format.

Suggested change

	- run: gh release edit --draft=false "$(./scripts/get-version.sh)"
	- run: gh release edit --draft=false "${{ github.ref_name }}"

[github-actions]

Hyperfine Performance

mise x -- echo

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2025.8.21 x -- echo	19.2 ± 0.5	18.5	25.1	1.00
mise x -- echo	19.4 ± 0.4	18.6	20.9	1.01 ± 0.04

mise env

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2025.8.21 env	18.7 ± 1.0	17.9	38.1	1.00
mise env	19.0 ± 0.7	18.1	23.8	1.02 ± 0.06

mise hook-env

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2025.8.21 hook-env	18.4 ± 0.4	17.6	19.5	1.00 ± 0.03
mise hook-env	18.4 ± 0.3	17.7	20.5	1.00

mise ls

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2025.8.21 ls	16.5 ± 0.3	16.0	17.5	1.00
mise ls	16.9 ± 0.4	16.1	18.2	1.02 ± 0.03

xtasks/test/perf

Command	mise-2025.8.21	mise	Variance
install (cached)	165ms	✅ 103ms	+60%
ls (cached)	63ms	63ms	+0%
bin-paths (cached)	66ms	66ms	+0%
task-ls (cached)	491ms	486ms	+1%

✅ Performance improvement: install cached is 60%