Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new pull request by comparing changes across two branches #1021

Merged
merged 25 commits into from
Aug 28, 2024

Commits on Aug 26, 2024

  1. src: change SetEncodedValue to return Maybe<void>

    With recent versions of V8, it is not necessary to use Maybe<bool>
    anymore. This changes SetEncodedValue to return Maybe<void> instead.
    
    PR-URL: #54443
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    tniessen committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c6a72f2 View commit details
    Browse the repository at this point in the history
  2. test: force spec reporter in test-runner-watch-mode.mjs

    In the CI this test generates TAP output that can confuse the
    Python test runner. Avoid the problem by not outputting TAP at
    from the spawned child process.
    
    Fixes: #54535
    PR-URL: #54538
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    cjihrig committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    05bd3cf View commit details
    Browse the repository at this point in the history
  3. src: use better return types in KVStore

    - Use `v8::Maybe<void>` instead of `v8::Maybe<bool>` and handle error
      from `AssignFromObject`.
    - An empty `v8::Maybe` is supposed to be returned when an exception is
      pending. Use `std::optional` instead to indicate a missing value in
      `Get(key)`.
    
    PR-URL: #54539
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    targos committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8f1fa03 View commit details
    Browse the repository at this point in the history
  4. src: return v8::Object from error constructors

    It's more specific than `v8::Value`.
    
    PR-URL: #54541
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    targos authored and nodejs-github-bot committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    eab97b5 View commit details
    Browse the repository at this point in the history
  5. src: handle errors correctly in permission.cc

    Return an empty `MaybeLocal` to indicate that an exception is pending.
    
    PR-URL: #54541
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    targos authored and nodejs-github-bot committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    4ce9864 View commit details
    Browse the repository at this point in the history
  6. src: handle errors correctly in webstorage

    PR-URL: #54544
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    targos committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    4f1c27a View commit details
    Browse the repository at this point in the history
  7. tools: remove unused python files

    PR-URL: #53928
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Ulises Gascón <[email protected]>
    RedYetiDev committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    3a71ccf View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. test: refactor test_runner tests to change default reporter

    This commit updates the test runner tests in order to switch the
    default reporter from tap to spec. This commit can be backported,
    while changing the default reporter cannot.
    
    Refs: #54540
    PR-URL: #54547
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    cjihrig committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    3d5357a View commit details
    Browse the repository at this point in the history
  2. deps: update c-ares to v1.33.1

    PR-URL: #54549
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    nodejs-github-bot committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    b39fad6 View commit details
    Browse the repository at this point in the history
  3. buffer: allow invalid encoding in from

    Looks like a bug to me but the change should probably
    done in a semver majpr.
    
    PR-URL: #54533
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    ronag committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    c00ea01 View commit details
    Browse the repository at this point in the history
  4. src: remove redundant AESCipherMode

    For each supported variant of AES, we already have OpenSSL's associated
    NID, so we can simply retrieve the block cipher mode of operation from
    the NID.
    
    PR-URL: #54438
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    tniessen committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    74ea78d View commit details
    Browse the repository at this point in the history
  5. buffer: truncate instead of throw when writing beyond buffer

    Fixes: #54523
    Fixes: #54518
    PR-URL: #54524
    Reviewed-By: Ethan Arrowood <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    ronag committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    dd8eeec View commit details
    Browse the repository at this point in the history
  6. node-api: remove RefBase and CallbackWrapper

    PR-URL: #53590
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Gabriel Schulhof <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    vmoroz committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    431ac16 View commit details
    Browse the repository at this point in the history
  7. src: move more crypto_dh.cc code to ncrypto

    Update deps/ncrypto/ncrypto.cc
    
    PR-URL: #54459
    Reviewed-By: Yagiz Nizipli <[email protected]>
    jasnell committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    6bf7b6e View commit details
    Browse the repository at this point in the history
  8. module: use amaro default transform values

    PR-URL: #54517
    Fixes: #54514
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Paolo Insogna <[email protected]>
    marco-ippolito committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    5e6aab0 View commit details
    Browse the repository at this point in the history
  9. zlib: simplify validators

    PR-URL: #54442
    Reviewed-By: James M Snell <[email protected]>
    anonrig committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    ba07067 View commit details
    Browse the repository at this point in the history
  10. test_runner: always make spec the default reporter

    This is a breaking change. Prior to this commit, the test_runner
    defaulted to the spec reporter if using a TTY, and the TAP
    reporter otherwise. This commit makes spec the default reporter
    unconditionally. TAP output is still available via the
    --test-reporter=tap CLI flag.
    
    Fixes: #54540
    PR-URL: #54548
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    cjihrig committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    eb7e18f View commit details
    Browse the repository at this point in the history
  11. doc: add note about shasum generation failure

    PR-URL: #54487
    Reviewed-By: Ulises Gascón <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    marco-ippolito committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    589a60e View commit details
    Browse the repository at this point in the history
  12. lib: fix emit warning for debuglog.time when disabled

    PR-URL: #54275
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    H4ad committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    a7271ab View commit details
    Browse the repository at this point in the history
  13. doc: support collaborators - talk amplification

    - document that we support collaborators by amplifying their talks
    
    Signed-off-by: Michael Dawson <[email protected]>
    PR-URL: #54508
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Ulises Gascón <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    mhdawson committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    d813634 View commit details
    Browse the repository at this point in the history
  14. deps: backport ICU-22787 to fix ClangCL on Windows

    - Floating patch for ICU 75.x
    
    ICU Bug: https://unicode-org.atlassian.net/browse/ICU-22787
    Backport of: unicode-org/icu#3023
    
    PR-URL: #54502
    Reviewed-By: Steven R Loomis <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    StefanStojanovic committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    ebaabf6 View commit details
    Browse the repository at this point in the history
  15. doc: fix information about including coverage files

    PR-URL: #54527
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    RedYetiDev committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    342b501 View commit details
    Browse the repository at this point in the history
  16. test: fix embedding test for Windows

    PR-URL: #53659
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Stefan Stojanovic <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    vmoroz committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    0b3ae01 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. doc: run license-builder

    PR-URL: #54562
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    github-actions[bot] committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    885692a View commit details
    Browse the repository at this point in the history
  2. Revert "net: validate host name for server listen"

    This reverts commit 52322aa.
    
    PR-URL: #54554
    Reviewed-By: Claudio Wunder <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Ulises Gascón <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    jakecastelli committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    4f14eb1 View commit details
    Browse the repository at this point in the history