src: handle errors correctly in webstorage #54544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
benjamingr
approved these changes
Aug 24, 2024
targos
force-pushed
the
maybe-webstorage
branch
from
74ab4e7
to
9c5158f
Compare
addaleax
approved these changes
Aug 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54544 +/- ##
==========================================
- Coverage 87.32% 87.32% -0.01%
==========================================
Files 649 649
Lines 182602 182599 -3
Branches 35033 35038 +5
==========================================
- Hits 159461 159458 -3
- Misses 16396 16403 +7
+ Partials 6745 6738 -7
|
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Aug 24, 2024
jasnell
approved these changes
Aug 24, 2024
This comment was marked as outdated.
This comment was marked as outdated.
targos
added
the
commit-queue
RedYetiDev
added
the
author ready
VoltrexKeyva
approved these changes
Aug 25, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4f1c27a |
RafaelGSS
added
the
backport-requested-v22.x
targos
added
backport-open-v22.x
targos
added a commit
to targos/node
that referenced
this pull request
Sep 1, 2024
PR-URL: nodejs#54544 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
|
Backport PR: #54683 |
targos
added a commit
to targos/node
that referenced
this pull request
Sep 5, 2024
PR-URL: nodejs#54544 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
targos
added a commit
to targos/node
that referenced
this pull request
Sep 16, 2024
PR-URL: nodejs#54544 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
targos
added a commit
that referenced
this pull request
Oct 6, 2024
PR-URL: #54544 Backport-PR-URL: #54683 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54544 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.