module: use amaro default transform values #54517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
module
RedYetiDev
added
blocked
|
I've added the blocked label, as this can't land until nodejs/amaro#71 does in #54520 |
benjamingr
approved these changes
Aug 23, 2024
marco-ippolito
force-pushed
the
use-amaro-defaults
branch
from
740d460
to
0365c1a
Compare
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54517 +/- ##
==========================================
- Coverage 87.33% 87.32% -0.02%
==========================================
Files 649 649
Lines 182626 182622 -4
Branches 35041 35037 -4
==========================================
- Hits 159503 159479 -24
- Misses 16394 16411 +17
- Partials 6729 6732 +3
|
marco-ippolito
added
the
author ready
ShogunPanda
approved these changes
Aug 27, 2024
marco-ippolito
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54517 ✔ Done loading data for nodejs/node/pull/54517 ----------------------------------- PR info ------------------------------------ Title module: use amaro default transform values (#54517) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch marco-ippolito:use-amaro-defaults -> nodejs:main Labels module, author ready, needs-ci, strip-types Commits 1 - module: use amaro default transform values Committers 1 - Marco Ippolito <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54517 Fixes: https://github.com/nodejs/node/issues/54514 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54517 Fixes: https://github.com/nodejs/node/issues/54514 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 23 Aug 2024 08:02:56 GMT ✔ Approvals: 2 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/54517#pullrequestreview-2257588131 ✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/54517#pullrequestreview-2263527893 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-08-27T11:46:10Z: https://ci.nodejs.org/job/node-test-pull-request/61542/ - Querying data for job/node-test-pull-request/61542/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10580234930 |
marco-ippolito
removed
the
commit-queue-failed
marco-ippolito
added a commit
that referenced
this pull request
Aug 27, 2024
PR-URL: #54517 Fixes: #54514 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
|
Landed in 5e6aab0 |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
PR-URL: #54517 Fixes: #54514 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
PR-URL: #54517 Fixes: #54514 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #54514
Moves the configuration of transformation into amaro but can always be override by node.
@nodejs/typescript