test: force spec reporter in test-runner-watch-mode.mjs #54538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
cjihrig
added
the
commit-queue-squash
lpinca
approved these changes
Aug 24, 2024
targos
approved these changes
Aug 24, 2024
|
Looks like some related failures in the GitHub CI because of all the places throughout the codebase where we already set the reporter to spec. I wonder if it might be worth shipping a breaking change to use the spec reporter by default in all cases. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54538 +/- ##
==========================================
- Coverage 87.33% 87.32% -0.01%
==========================================
Files 649 649
Lines 182603 182603
Branches 35035 35036 +1
==========================================
- Hits 159474 159457 -17
- Misses 16396 16404 +8
- Partials 6733 6742 +9 |
In the CI this test generates TAP output that can confuse the Python test runner. Avoid the problem by not outputting TAP at from the spawned child process. Fixes: nodejs#54535
benjamingr
approved these changes
Aug 24, 2024
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
cjihrig
added
commit-queue
jasnell
approved these changes
Aug 25, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in 05bd3cf |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
In the CI this test generates TAP output that can confuse the Python test runner. Avoid the problem by not outputting TAP at from the spawned child process. Fixes: #54535 PR-URL: #54538 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
In the CI this test generates TAP output that can confuse the Python test runner. Avoid the problem by not outputting TAP at from the spawned child process. Fixes: #54535 PR-URL: #54538 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
targos
added
the
dont-land-on-v20.x
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
In the CI this test generates TAP output that can confuse the Python test runner. Avoid the problem by not outputting TAP at from the spawned child process. Fixes: nodejs#54535 PR-URL: nodejs#54538 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the CI this test generates TAP output that can confuse the Python test runner. Avoid the problem by not outputting TAP at all.
Fixes: #54535