Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: remove unused python files #53928

Merged
merged 1 commit into from
Aug 26, 2024
Merged

tools: remove unused python files #53928

merged 1 commit into from
Aug 26, 2024
+0 −17

Conversation

RedYetiDev
Copy link
Member

These files aren't used internally, so this PR removes them.

getarch.py

image

getendian.py

image

getmachine.py

image

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jul 18, 2024
@RedYetiDev RedYetiDev added the python PRs and issues that require attention from people who are familiar with Python. label Jul 18, 2024
@RedYetiDev RedYetiDev changed the title python: remove unused files tools: remove unused python files Jul 18, 2024
@RedYetiDev
Copy link
Member Author

This hasn't seen any objections in weeks, can it land?

@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 11, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 11, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61006/

@RedYetiDev
Copy link
Member Author

RedYetiDev commented Aug 13, 2024 •
edited
Loading

CI is passing, commit-queue or author ready...? This should be good to land.

@jasnell @lpinca @MoLow

@UlisesGascon UlisesGascon added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 26, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 26, 2024
@nodejs-github-bot nodejs-github-bot merged commit 3a71ccf into nodejs:main Aug 26, 2024
56 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 3a71ccf

RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@RedYetiDev @RafaelGSS
tools: remove unused python files
7fd514f 
PR-URL: #53928
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@RedYetiDev @RafaelGSS
tools: remove unused python files
3879814 
PR-URL: #53928
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RedYetiDev @nodejs-github-bot @jasnell @lpinca @UlisesGascon @MoLow