Revert "net: validate host name for server listen" #54554

jakecastelli · 2024-08-25T15:48:40Z

This reverts commit 52322aa.

Both PRs #54264 and #54470 made changes to the ipv6 related code base (net) and the latter caused the Github CI to break (break the test that added in the earlier PR). ~~We should revert the change and properly fix the test before #54470 can land again to unblock the CI.~~

Update: Luigi has gone ahead and fixed the broken tests in #54556.
Update: More issues were identified, reopened again to revert it.

This reverts commit 52322aa.

nodejs-github-bot · 2024-08-25T15:48:45Z

Review requested:

@nodejs/net

RedYetiDev · 2024-08-25T16:07:46Z

CC @jazelly

ovflowd · 2024-08-25T16:11:47Z

@jakecastelli are you looking into having this fast tracked?

github-actions · 2024-08-25T16:13:08Z

Fast-track has been requested by @jakecastelli. Please 👍 to approve.

ovflowd · 2024-08-25T16:14:19Z

@jakecastelli your own 👍 doesn't count for the fast-track request. So another collaborator is needed to fast track.

jakecastelli · 2024-08-25T16:17:49Z

@jakecastelli your own 👍 doesn't count for the fast-track request. So another collaborator is needed to fast track.

Thanks for the heads up 🙏

nodejs-github-bot · 2024-08-25T16:33:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61454/

codecov · 2024-08-25T17:16:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.35%. Comparing base (52322aa) to head (c3653d2).
Report is 27 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54554      +/-   ##
==========================================
+ Coverage   87.33%   87.35%   +0.01%     
==========================================
  Files         649      649              
  Lines      182626   182618       -8     
  Branches    35035    35045      +10     
==========================================
+ Hits       159498   159519      +21     
+ Misses      16400    16382      -18     
+ Partials     6728     6717      -11

Files	Coverage Δ
lib/net.js	`92.81% <ø> (+0.21%)`	⬆️

... and 26 files with indirect coverage changes

lpinca · 2024-08-25T17:39:45Z

Can't we simply fix the test instead of reverting this?

Use valid hostnames in `test/sequential/test-net-server-listen-ipv6-link-local.js`. Refs: nodejs#54554

RedYetiDev · 2024-08-25T19:49:37Z

See #54556 as well

Use valid hostnames in `test/sequential/test-net-server-listen-ipv6-link-local.js`. Refs: #54554 PR-URL: #54556 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

aduh95 · 2024-08-25T22:45:35Z

Removing fast-track PRs that do not need to wait for 48 hours to land. as the other PR was merged, which IIUC also fixes the CI. Do we still want to land this?

jakecastelli · 2024-08-25T23:06:52Z

Thanks guys for looking into this 🙏 it was nearly 1:30 A.M. when I found this issue and I wasn't sure if there is going to be more issues, the safest way comes to my mind was raising the issue, reverting (as I knew prior to this commit it was green), run CI, maybe land when I wake up 😄 but thanks @lpinca for looking into and fixing it and also everyone else who helped here!

Do we still want to land this?

~~Since the Github Actions / CI is green, we don't want to land this anymore 👍 if there are bugs, we can always send patches instead.~~

Update: Yes, we found bigger issue with that commit, and we need to revert the commit.

Use valid hostnames in `test/sequential/test-net-server-listen-ipv6-link-local.js`. Refs: nodejs#54554 PR-URL: nodejs#54556 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

jazelly · 2024-08-26T06:35:40Z

I started to think that we should revert that commit.

By looking at the implementation of server.listen, it accepts IDNs, so enforcing the host with only Ascii characters at this layer might not be appropriate.

nodejs-github-bot · 2024-08-26T07:00:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61471/

nodejs-github-bot · 2024-08-26T09:53:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61477/

jakecastelli · 2024-08-26T09:56:29Z

Looks like we started the rerun around the same time @lpinca, I will cancel mine (as mine appears to be late 😄)
Update: cancelled and marked as outdated.

jakecastelli · 2024-08-26T12:57:23Z

test-http2-socket-close has been extremely flaky 😞

nodejs-github-bot · 2024-08-26T12:58:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61486/

nodejs-github-bot · 2024-08-26T14:06:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61491/ 💚

nodejs-github-bot · 2024-08-27T15:57:04Z

Commit Queue failed

- Loading data for nodejs/node/pull/54554
✔  Done loading data for nodejs/node/pull/54554
----------------------------------- PR info ------------------------------------
Title      Revert "net: validate host name for server listen" (#54554)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     jakecastelli:revert-52322aa -> nodejs:main
Labels     net, needs-ci, revert
Commits    1
 - Revert "net: validate host name for server listen"
Committers 1
 - jakecastelli <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/54554
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54554
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 25 Aug 2024 15:48:40 GMT
   ✔  Approvals: 5
   ✔  - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/54554#pullrequestreview-2259334489
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54554#pullrequestreview-2259336303
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54554#pullrequestreview-2261077656
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/54554#pullrequestreview-2259348797
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/54554#pullrequestreview-2261429112
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2024-08-26T14:06:43Z: https://ci.nodejs.org/job/node-test-pull-request/61491/
- Querying data for job/node-test-pull-request/61491/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/10581610536

jakecastelli · 2024-08-28T07:49:45Z

Last GitHub CI failed

This is not true 😞 landing manually now

This reverts commit 52322aa. PR-URL: #54554 Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

jakecastelli · 2024-08-28T07:59:33Z

Landed in 4f14eb1

Gguyzaza · 2024-08-28T08:09:10Z

Ok

Use valid hostnames in `test/sequential/test-net-server-listen-ipv6-link-local.js`. Refs: #54554 PR-URL: #54556 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

This reverts commit 52322aa. PR-URL: #54554 Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Use valid hostnames in `test/sequential/test-net-server-listen-ipv6-link-local.js`. Refs: #54554 PR-URL: #54556 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

This reverts commit 52322aa. PR-URL: #54554 Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Revert "net: validate host name for server listen"

c3653d2

This reverts commit 52322aa.

nodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Aug 25, 2024

jakecastelli mentioned this pull request Aug 25, 2024

test: refactor test_runner tests to change default reporter #54547

Merged

RedYetiDev added the revert PRs that revert previously landed PRs. label Aug 25, 2024

ovflowd approved these changes Aug 25, 2024

View reviewed changes

jakecastelli added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 25, 2024

jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 25, 2024

jasnell approved these changes Aug 25, 2024

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 25, 2024

lpinca approved these changes Aug 25, 2024

View reviewed changes

lpinca added a commit to lpinca/node that referenced this pull request Aug 25, 2024

test: use valid hostnames

2d7aee7

Use valid hostnames in `test/sequential/test-net-server-listen-ipv6-link-local.js`. Refs: nodejs#54554

lpinca mentioned this pull request Aug 25, 2024

test: use valid hostnames #54556

Merged

UlisesGascon approved these changes Aug 25, 2024

View reviewed changes

aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Aug 25, 2024

jakecastelli closed this Aug 25, 2024

jakecastelli mentioned this pull request Aug 26, 2024

doc: improve the process for landing a PR #54564

Closed

lpinca reopened this Aug 26, 2024

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2024

This comment was marked as outdated.

Sign in to view

lpinca approved these changes Aug 26, 2024

View reviewed changes

benjamingr approved these changes Aug 26, 2024

View reviewed changes

benjamingr added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 26, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 27, 2024

jakecastelli closed this Aug 28, 2024

jakecastelli removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Aug 28, 2024

RafaelGSS mentioned this pull request Aug 30, 2024

v22.8.0 proposal #54560

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "net: validate host name for server listen" #54554

Revert "net: validate host name for server listen" #54554

jakecastelli commented Aug 25, 2024 •

edited

Loading

nodejs-github-bot commented Aug 25, 2024

RedYetiDev commented Aug 25, 2024

ovflowd commented Aug 25, 2024

github-actions bot commented Aug 25, 2024

ovflowd commented Aug 25, 2024

jakecastelli commented Aug 25, 2024

nodejs-github-bot commented Aug 25, 2024

codecov bot commented Aug 25, 2024 •

edited

Loading

lpinca commented Aug 25, 2024 •

edited

Loading

RedYetiDev commented Aug 25, 2024

aduh95 commented Aug 25, 2024 •

edited

Loading

jakecastelli commented Aug 25, 2024 •

edited

Loading

jazelly commented Aug 26, 2024 •

edited

Loading

nodejs-github-bot commented Aug 26, 2024

nodejs-github-bot commented Aug 26, 2024

This comment was marked as outdated.

jakecastelli commented Aug 26, 2024 •

edited

Loading

jakecastelli commented Aug 26, 2024

nodejs-github-bot commented Aug 26, 2024

nodejs-github-bot commented Aug 26, 2024 •

edited by jakecastelli

Loading

nodejs-github-bot commented Aug 27, 2024

jakecastelli commented Aug 28, 2024

jakecastelli commented Aug 28, 2024

Gguyzaza commented Aug 28, 2024

Revert "net: validate host name for server listen" #54554

Revert "net: validate host name for server listen" #54554

Conversation

jakecastelli commented Aug 25, 2024 • edited Loading

nodejs-github-bot commented Aug 25, 2024

RedYetiDev commented Aug 25, 2024

ovflowd commented Aug 25, 2024

github-actions bot commented Aug 25, 2024

ovflowd commented Aug 25, 2024

jakecastelli commented Aug 25, 2024

nodejs-github-bot commented Aug 25, 2024

codecov bot commented Aug 25, 2024 • edited Loading

Codecov Report

lpinca commented Aug 25, 2024 • edited Loading

RedYetiDev commented Aug 25, 2024

aduh95 commented Aug 25, 2024 • edited Loading

jakecastelli commented Aug 25, 2024 • edited Loading

jazelly commented Aug 26, 2024 • edited Loading

nodejs-github-bot commented Aug 26, 2024

nodejs-github-bot commented Aug 26, 2024

This comment was marked as outdated.

jakecastelli commented Aug 26, 2024 • edited Loading

jakecastelli commented Aug 26, 2024

nodejs-github-bot commented Aug 26, 2024

nodejs-github-bot commented Aug 26, 2024 • edited by jakecastelli Loading

nodejs-github-bot commented Aug 27, 2024

jakecastelli commented Aug 28, 2024

jakecastelli commented Aug 28, 2024

Gguyzaza commented Aug 28, 2024

jakecastelli commented Aug 25, 2024 •

edited

Loading

codecov bot commented Aug 25, 2024 •

edited

Loading

lpinca commented Aug 25, 2024 •

edited

Loading

aduh95 commented Aug 25, 2024 •

edited

Loading

jakecastelli commented Aug 25, 2024 •

edited

Loading

jazelly commented Aug 26, 2024 •

edited

Loading

jakecastelli commented Aug 26, 2024 •

edited

Loading

nodejs-github-bot commented Aug 26, 2024 •

edited by jakecastelli

Loading