Ensure e2e tests use the correct versions yaml file

[luksa]

We use -ldflags to set the istioversion.versionsFilename variable, but this only works when building the binary. It doesn't work when running ginkgo-based e2e tests. When the versionsFilename is not set via ldflags, it will now use the environment variable VERSIONS_YAML_FILE. If this env var isn't set, we default to versions.yaml.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.16%. Comparing base (e6c2390) to head (19d9ddf).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
- Coverage   74.57%   74.16%   -0.42%     
==========================================
  Files          42       43       +1     
  Lines        2584     2597      +13     
==========================================
- Hits         1927     1926       -1     
- Misses        565      577      +12     
- Partials       92       94       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fjglira]

There is already an env.Get defined in the e2e util package:

sail-operator/tests/e2e/util/env/env.go

Lines 26 to 27 in 72c1264

	func Get(key, defaultValue string) string {
	value := os.Getenv(key)

Maybe worth moving it to a common place and used it both in the version.go and in the e2e test. wdyt?

[luksa]

Yes, you're absolutely right.

I've moved it to pkg/env, but I had to remove the ginkgo logging. I hated that thing anyway, because it got printed even when the tests weren't running in verbose mode. If we need those lines, we should move print them somewhere else.

[fjglira]

Just a minor comment

[istio-testing]

In response to a cherrypick label: #667 failed to apply on top of branch "release-1.0":

Applying: Ensure e2e tests use the correct versions yaml file
Using index info to reconstruct a base tree...
M	tests/e2e/ambient/ambient_suite_test.go
M	tests/e2e/controlplane/control_plane_suite_test.go
M	tests/e2e/dualstack/dualstack_suite_test.go
M	tests/e2e/multicluster/multicluster_suite_test.go
A	tests/e2e/multicontrolplane/multi_control_plane_suite_test.go
M	tests/e2e/operator/operator_suite_test.go
M	tests/e2e/util/common/e2e_utils.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/util/common/e2e_utils.go
Auto-merging tests/e2e/operator/operator_suite_test.go
CONFLICT (modify/delete): tests/e2e/multicontrolplane/multi_control_plane_suite_test.go deleted in HEAD and modified in Ensure e2e tests use the correct versions yaml file. Version Ensure e2e tests use the correct versions yaml file of tests/e2e/multicontrolplane/multi_control_plane_suite_test.go left in tree.
Auto-merging tests/e2e/multicluster/multicluster_suite_test.go
Auto-merging tests/e2e/dualstack/dualstack_suite_test.go
Auto-merging tests/e2e/controlplane/control_plane_suite_test.go
Auto-merging tests/e2e/ambient/ambient_suite_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Ensure e2e tests use the correct versions yaml file

[istio-testing]

In response to a cherrypick label: new issue created for failed cherrypick: #668