Do not remove everything from resources directory#667
Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-service-mesh:mainfrom Feb 4, 2026
Merged
Conversation
istio-ecosystem#1561 added new file to resources directory so we can't remove everything. We want to remove just charts.
Author
|
/override ci/prow/ocp-4.20-e2e-ocp ci/prow/ocp-4.20-e2e-ocp-arm ci/prow/ocp-4.21-e2e-ocp |
|
@FilipB: Overrode contexts on behalf of FilipB: ci/prow/ocp-4.20-e2e-ocp, ci/prow/ocp-4.20-e2e-ocp-arm, ci/prow/ocp-4.21-e2e-ocp DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6f4d74f
into
openshift-service-mesh:main
8 checks passed
|
In response to a cherrypick label: #667 failed to apply on top of branch "release-3.2": |
|
In response to a cherrypick label: #667 failed to apply on top of branch "release-3.3": |
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
istio-ecosystem#1561 added new file to resources directory so we can't remove everything. We want to remove just charts.
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
istio-ecosystem#1561 added new file to resources directory so we can't remove everything. We want to remove just charts.
dcillera
pushed a commit
to dcillera/sail-operator
that referenced
this pull request
Mar 19, 2026
…e-mesh#667) (openshift-service-mesh#669) (openshift-service-mesh#254) We use `-ldflags` to set the `istioversion.versionsFilename` variable, but this only works when building the binary. It doesn't work when running ginkgo-based e2e tests. When the `versionsFilename` is not set via ldflags, it will now use the environment variable `VERSIONS_YAML_FILE`. If this env var isn't set, we default to `versions.yaml`. (cherry picked from commit 148eb64) Signed-off-by: Marko Lukša <mluksa@redhat.com>
dcillera
pushed a commit
to dcillera/sail-operator
that referenced
this pull request
Mar 19, 2026
…e-mesh#667) (openshift-service-mesh#669) We use `-ldflags` to set the `istioversion.versionsFilename` variable, but this only works when building the binary. It doesn't work when running ginkgo-based e2e tests. When the `versionsFilename` is not set via ldflags, it will now use the environment variable `VERSIONS_YAML_FILE`. If this env var isn't set, we default to `versions.yaml`. (cherry picked from commit 148eb64) Signed-off-by: Marko Lukša <mluksa@redhat.com>
dcillera
pushed a commit
to dcillera/sail-operator
that referenced
this pull request
Mar 19, 2026
* upstream/release-1.0: Make environment variable consistent (openshift-service-mesh#664) Add multi control plane e2e tests (openshift-service-mesh#610) (openshift-service-mesh#670) Ensure e2e tests use the correct versions yaml file (openshift-service-mesh#667) (openshift-service-mesh#669) Add version alias support (openshift-service-mesh#566) (openshift-service-mesh#662) Add missing link for: Example using the RevisionBased strategy and an IstioRevisionTag # Conflicts: # bundle/manifests/sailoperator.clusterserviceversion.yaml
hhovsepy
pushed a commit
to hhovsepy/sail-operator
that referenced
this pull request
Apr 8, 2026
…e-mesh#667) We use `-ldflags` to set the `istioversion.versionsFilename` variable, but this only works when building the binary. It doesn't work when running ginkgo-based e2e tests. When the `versionsFilename` is not set via ldflags, it will now use the environment variable `VERSIONS_YAML_FILE`. If this env var isn't set, we default to `versions.yaml`. Signed-off-by: Marko Lukša <mluksa@redhat.com>
hhovsepy
pushed a commit
to hhovsepy/sail-operator
that referenced
this pull request
Apr 8, 2026
* e2e multicluster test improve Signed-off-by: Francisco H <frherrer@redhat.com> Clean up multicluister test Signed-off-by: Francisco H <frherrer@redhat.com> Adding primary remote multicluster e2e test Signed-off-by: Francisco H <frherrer@redhat.com> Ensure e2e tests use the correct versions yaml file (openshift-service-mesh#667) We use `-ldflags` to set the `istioversion.versionsFilename` variable, but this only works when building the binary. It doesn't work when running ginkgo-based e2e tests. When the `versionsFilename` is not set via ldflags, it will now use the environment variable `VERSIONS_YAML_FILE`. If this env var isn't set, we default to `versions.yaml`. Signed-off-by: Marko Lukša <mluksa@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> e2e multicluster test improve Signed-off-by: Francisco H <frherrer@redhat.com> Fix lint errors Signed-off-by: Francisco H <frherrer@redhat.com> Delete references to bookinfo on multicluster test Signed-off-by: Francisco H <frherrer@redhat.com> Fix change package on external multicluster test Signed-off-by: Francisco H <frherrer@redhat.com> * Apply suggestions from code review Co-authored-by: Nick Fox <6226732+nrfox@users.noreply.github.com> Signed-off-by: Francisco H <frherrer@redhat.com> * Changes from review Signed-off-by: Francisco H <frherrer@redhat.com> * More changes from review Signed-off-by: Francisco H <frherrer@redhat.com> * Add tag to common file in multicluster test Signed-off-by: Francisco H <frherrer@redhat.com> * Delete duplicated Label Signed-off-by: Francisco H <frherrer@redhat.com> --------- Signed-off-by: Francisco H <frherrer@redhat.com> Co-authored-by: Nick Fox <6226732+nrfox@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
istio-ecosystem#1561 added new file to resources directory so we can't remove everything. We want to remove just charts.