Make environment variable consistent#663
Conversation
Signed-off-by: Yann Liu <yannliu@redhat.com>
|
Hi @yannuil. Thanks for your PR. I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.0 |
|
@yannuil: only istio-ecosystem org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #663 +/- ##
==========================================
+ Coverage 74.41% 74.57% +0.15%
==========================================
Files 42 42
Lines 2584 2584
==========================================
+ Hits 1923 1927 +4
+ Misses 568 565 -3
+ Partials 93 92 -1 ☔ View full report in Codecov by Sentry. |
|
/cherry-pick release-1.0 |
|
@fjglira: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
@fjglira: new pull request created: #664 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* upstream-eco/main: Ensure e2e tests use the correct versions yaml file (istio-ecosystem#667) Make environment variable consistent (istio-ecosystem#663) Add contributor meeting information to the contributor.md file (istio-ecosystem#623) Add version alias support (istio-ecosystem#566)
Co-authored-by: openshift-service-mesh-bot <null>
Signed-off-by: Yann Liu <yannliu@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
4 participants
What type of PR is this?
What this PR does / why we need it:
VERSIONS_YAML_FILEis used to referenced only the filename any other places in codebase. This PR makes the usage consistent.