Add contributor meeting information to the contributor.md file#623
Conversation
fjglira
force-pushed
the
update-community-meetings
branch
from
49a73fc to
41af039
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #623 +/- ##
==========================================
+ Coverage 74.19% 74.41% +0.22%
==========================================
Files 40 42 +2
Lines 2511 2584 +73
==========================================
+ Hits 1863 1923 +60
- Misses 558 568 +10
- Partials 90 93 +3 ☔ View full report in Codecov by Sentry. |
CONTRIBUTING.md
Outdated
| ## Community meetings | ||
|
|
||
| This is not defined yet. We are working on defining the community meetings and how the community can participate in them. We will update this section once we have more information. | ||
| The Sail Operator project has a weekly contributor call every Thursday at 4PM CET / 10AM EST (Check your local time) to discuss the project status, features, isues, and other topics related to the project. You can join the meeting by using the [link](https://www.google.com/url?q=https://meet.google.com/uxg-wcfp-opv&sa=D&source=calendar&ust=1739288261191644&usg=AOvVaw08ZzxMrcPskBFK5rLxUACC), also the agenda and notes are available in the following [link](https://docs.google.com/document/d/1p1gx7dC8XQwFtv6l0zQbZjObAVJVTOBH2PvLVX6wU_0/edit?usp=sharing). If you want to suggest a topic please open an issue in the [Sail Operator GitHub repository](https://github.com/istio-ecosystem/sail-operator/issues) or start a discussion in the [Sail Operator Discussion](https://github.com/istio-ecosystem/sail-operator/discussions) and mention the `contributor-meeting` label. |
There was a problem hiding this comment.
Why does the link go through www.google.com instead of directly to meet.google.com?
There was a problem hiding this comment.
We can replace the meeting url with https://meet.google.com/uxg-wcfp-opv
CONTRIBUTING.md
Outdated
| ## Community meetings | ||
|
|
||
| This is not defined yet. We are working on defining the community meetings and how the community can participate in them. We will update this section once we have more information. | ||
| The Sail Operator project has a weekly contributor call every Thursday at 4PM CET / 10AM EST (Check your local time) to discuss the project status, features, isues, and other topics related to the project. You can join the meeting by using the [link](https://meet.google.com/uxg-wcfp-opv), also the agenda and notes are available in the following [link](https://docs.google.com/document/d/1p1gx7dC8XQwFtv6l0zQbZjObAVJVTOBH2PvLVX6wU_0/edit?usp=sharing). If you want to suggest a topic please open an issue in the [Sail Operator GitHub repository](https://github.com/istio-ecosystem/sail-operator/issues) or start a discussion in the [Sail Operator Discussion](https://github.com/istio-ecosystem/sail-operator/discussions) and mention the `contributor-meeting` label. |
There was a problem hiding this comment.
I don't recall any discussion about the contributor-meeting label, and I don't see it in Sail Operator either.
That doesn't mean we can't use it, I'm just curious if there was a discussion where this label was finalized.
There was a problem hiding this comment.
There was no discussion about this yet; the idea was to discuss it here :). I proposed because we will need a way to propose topics without having to open the meeting document to everyone. It can also be done by making suggestions in the document, but I think it is an "uglier" solution. Creating discussion in the section will allow us to filter even the topics there or respond to those topics directly there
There was a problem hiding this comment.
I'm okay with using the label if the team decides to go with it. However, we should also add a note mentioning that people can add agenda items to the doc, as this is the common practice in Istio and other open-source projects.
There was a problem hiding this comment.
Hey @dgn, wdyt? Is there a way to also open the document, but filtering in some way only authenticated the user to avoid someone entering the docs and making a mess?
There was a problem hiding this comment.
The document is open for the public to view, comment and add suggestions, to we don't need to use a label. All edits have to be approved by a maintainer so we don't have to fear somebody anonymously adding or deleting information
There was a problem hiding this comment.
The Istio combined working group doc seems to be open (including editor access) to everyone, but I'm fine if we want to give comment access to the Sail Operator agenda doc and let maintainers approve any suggestions/items.
There was a problem hiding this comment.
Ok, I'll edit the text and leave only the information about the meeting
There was a problem hiding this comment.
@sridhargaddam I made the changes and keep it simple
Signed-off-by: Francisco H <frherrer@redhat.com>
Signed-off-by: Francisco H <frherrer@redhat.com>
Signed-off-by: Francisco H <frherrer@redhat.com>
Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com>
fjglira
force-pushed
the
update-community-meetings
branch
from
6445d17 to
dd1de50
Compare
* upstream-eco/main: Ensure e2e tests use the correct versions yaml file (istio-ecosystem#667) Make environment variable consistent (istio-ecosystem#663) Add contributor meeting information to the contributor.md file (istio-ecosystem#623) Add version alias support (istio-ecosystem#566)
Co-authored-by: openshift-service-mesh-bot <null>
…-ecosystem#623) * Add contributyor meeting information to the contributor.md file Signed-off-by: Francisco H <frherrer@redhat.com> * Update link Signed-off-by: Francisco H <frherrer@redhat.com> * Update contributing file based on comments Signed-off-by: Francisco H <frherrer@redhat.com> * Update CONTRIBUTING.md Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> --------- Signed-off-by: Francisco H <frherrer@redhat.com> Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
5 participants
What type of PR is this?
What this PR does / why we need it:
Update the contributor.md file to add the information about weekly contributors meeting
Which issue(s) this PR fixes:
Fixes #
Related Issue/PR #
Additional information: