[release-1.0] Ensure e2e tests use the correct versions yaml file (#667)#669
Merged
istio-testing merged 1 commit intoistio-ecosystem:release-1.0from Feb 19, 2025
Merged
Conversation
) We use `-ldflags` to set the `istioversion.versionsFilename` variable, but this only works when building the binary. It doesn't work when running ginkgo-based e2e tests. When the `versionsFilename` is not set via ldflags, it will now use the environment variable `VERSIONS_YAML_FILE`. If this env var isn't set, we default to `versions.yaml`. Signed-off-by: Marko Lukša <mluksa@redhat.com> (cherry picked from commit 148eb64) Signed-off-by: Marko Lukša <mluksa@redhat.com>
sridhargaddam
approved these changes
Feb 19, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.0 #669 +/- ##
===============================================
- Coverage 74.57% 74.27% -0.30%
===============================================
Files 42 43 +1
Lines 2584 2597 +13
===============================================
+ Hits 1927 1929 +2
- Misses 565 575 +10
- Partials 92 93 +1 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
/retest |
luksa
added a commit
to luksa/sail-operator
that referenced
this pull request
Feb 19, 2025
) (istio-ecosystem#669) We use `-ldflags` to set the `istioversion.versionsFilename` variable, but this only works when building the binary. It doesn't work when running ginkgo-based e2e tests. When the `versionsFilename` is not set via ldflags, it will now use the environment variable `VERSIONS_YAML_FILE`. If this env var isn't set, we default to `versions.yaml`. (cherry picked from commit 148eb64) Signed-off-by: Marko Lukša <mluksa@redhat.com>
openshift-merge-bot bot
referenced
this pull request
in openshift-service-mesh/sail-operator
Feb 19, 2025
We use `-ldflags` to set the `istioversion.versionsFilename` variable, but this only works when building the binary. It doesn't work when running ginkgo-based e2e tests. When the `versionsFilename` is not set via ldflags, it will now use the environment variable `VERSIONS_YAML_FILE`. If this env var isn't set, we default to `versions.yaml`. (cherry picked from commit 148eb64) Signed-off-by: Marko Lukša <mluksa@redhat.com>
openshift-service-mesh-bot
referenced
this pull request
in openshift-service-mesh-bot/sail-operator
Feb 24, 2025
* upstream/release-1.0: Make environment variable consistent (openshift-service-mesh#664) Add multi control plane e2e tests (openshift-service-mesh#610) (openshift-service-mesh#670) Ensure e2e tests use the correct versions yaml file (openshift-service-mesh#667) (openshift-service-mesh#669) Add version alias support (openshift-service-mesh#566) (openshift-service-mesh#662) Add missing link for: Example using the RevisionBased strategy and an IstioRevisionTag # Conflicts: # bundle/manifests/sailoperator.clusterserviceversion.yaml
yannuil
pushed a commit
to yannuil/sail-operator
that referenced
this pull request
Jun 20, 2025
) (istio-ecosystem#669) (istio-ecosystem#254) We use `-ldflags` to set the `istioversion.versionsFilename` variable, but this only works when building the binary. It doesn't work when running ginkgo-based e2e tests. When the `versionsFilename` is not set via ldflags, it will now use the environment variable `VERSIONS_YAML_FILE`. If this env var isn't set, we default to `versions.yaml`. (cherry picked from commit 148eb64) Signed-off-by: Marko Lukša <mluksa@redhat.com>
mkralik3
pushed a commit
to mkralik3/sail-operator
that referenced
this pull request
Mar 23, 2026
Co-authored-by: openshift-service-mesh-bot <null>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use
-ldflagsto set theistioversion.versionsFilenamevariable, but this only works when building the binary. It doesn't work when running ginkgo-based e2e tests. When theversionsFilenameis not set via ldflags, it will now use the environment variableVERSIONS_YAML_FILE. If this env var isn't set, we default toversions.yaml.(cherry picked from commit 148eb64)
Fixes: #668