[Manual Cherry-pick] Add external controlplane e2e test (#676)#693
Closed
fjglira wants to merge 1 commit intoistio-ecosystem:release-1.0from
Closed
[Manual Cherry-pick] Add external controlplane e2e test (#676)#693fjglira wants to merge 1 commit intoistio-ecosystem:release-1.0from
fjglira wants to merge 1 commit intoistio-ecosystem:release-1.0from
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.0 #693 +/- ##
===============================================
+ Coverage 74.16% 74.31% +0.15%
===============================================
Files 43 43
Lines 2597 2597
===============================================
+ Hits 1926 1930 +4
+ Misses 577 574 -3
+ Partials 94 93 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* e2e multicluster test improve Signed-off-by: Francisco H <frherrer@redhat.com> Clean up multicluister test Signed-off-by: Francisco H <frherrer@redhat.com> Adding primary remote multicluster e2e test Signed-off-by: Francisco H <frherrer@redhat.com> Ensure e2e tests use the correct versions yaml file (istio-ecosystem#667) We use `-ldflags` to set the `istioversion.versionsFilename` variable, but this only works when building the binary. It doesn't work when running ginkgo-based e2e tests. When the `versionsFilename` is not set via ldflags, it will now use the environment variable `VERSIONS_YAML_FILE`. If this env var isn't set, we default to `versions.yaml`. Signed-off-by: Marko Lukša <mluksa@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> e2e multicluster test improve Signed-off-by: Francisco H <frherrer@redhat.com> Fix lint errors Signed-off-by: Francisco H <frherrer@redhat.com> Delete references to bookinfo on multicluster test Signed-off-by: Francisco H <frherrer@redhat.com> Fix change package on external multicluster test Signed-off-by: Francisco H <frherrer@redhat.com> * Apply suggestions from code review Co-authored-by: Nick Fox <6226732+nrfox@users.noreply.github.com> Signed-off-by: Francisco H <frherrer@redhat.com> * Changes from review Signed-off-by: Francisco H <frherrer@redhat.com> * More changes from review Signed-off-by: Francisco H <frherrer@redhat.com> * Add tag to common file in multicluster test Signed-off-by: Francisco H <frherrer@redhat.com> * Delete duplicated Label Signed-off-by: Francisco H <frherrer@redhat.com> --------- Signed-off-by: Francisco H <frherrer@redhat.com> Co-authored-by: Nick Fox <6226732+nrfox@users.noreply.github.com>
Contributor
Author
|
1.0 was released without the change, closing this PR. It's not needed anymore |
zmiklank
pushed a commit
to zmiklank/sail-operator
that referenced
this pull request
Mar 16, 2026
Co-authored-by: bmangoen <9867932+bmangoen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up multicluister test
Adding primary remote multicluster e2e test
Ensure e2e tests use the correct versions yaml file (#667)
We use
-ldflagsto set theistioversion.versionsFilenamevariable, but this only works when building the binary. It doesn't work when running ginkgo-based e2e tests. When theversionsFilenameis not set via ldflags, it will now use the environment variableVERSIONS_YAML_FILE. If this env var isn't set, we default toversions.yaml.e2e multicluster test improve
Fix lint errors
Delete references to bookinfo on multicluster test
Fix change package on external multicluster test
Apply suggestions from code review
Changes from review
More changes from review
Add tag to common file in multicluster test
Delete duplicated Label
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #685
Related Issue/PR #
Additional information: