Reolink test init 100%#89112
Merged
Merged
Conversation
home-assistant
Bot
added
cla-signed
code-quality
has-tests
integration: reolink
small-pr
frenck
requested changes
Mar 4, 2023
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
frenck
requested changes
Mar 6, 2023
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
epenet
requested changes
Mar 7, 2023
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
frenck
requested changes
Mar 7, 2023
frenck
approved these changes
Mar 7, 2023
Member
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
Looks good to me now, thanks @starkillerOG 👍
@epenet are you ok with the changes?
epenet
approved these changes
Mar 7, 2023
jpbaltazar
pushed a commit
to jpbaltazar/inels-home-assistant
that referenced
this pull request
Mar 8, 2023
* Split out reolink tests * Bring __init__ coverage to 100% * Improve docstrings * Use patching and autospec=True for ReolinkHost * Use fixture * fix styling * Parametrize tests * Update tests/components/reolink/conftest.py Co-authored-by: Franck Nijhof <frenck@frenck.nl> * Apply suggestions from code review Co-authored-by: Franck Nijhof <frenck@frenck.nl> * Update test_config_flow.py * convert to fixture * review comments * Update tests/components/reolink/conftest.py Co-authored-by: epenet <6771947+epenet@users.noreply.github.com> * Update tests/components/reolink/conftest.py Co-authored-by: epenet <6771947+epenet@users.noreply.github.com> * Update tests/components/reolink/conftest.py Co-authored-by: epenet <6771947+epenet@users.noreply.github.com> * fix tests * fix imports * Update test_init.py * Check if host is logout on reload --------- Co-authored-by: Franck Nijhof <frenck@frenck.nl> Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Clean up reolink tests and fixtures.
Bring test coverage for the init.py file to 100% for the Reolink integration.
Requested by @epenet in this PR: #88903 (comment)
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: