Improve reolink generic typing

[cdce8p]

Proposed change

Improve generic typing around CoordinatorEntity and DataUpdateCoordinator.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (reolink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of reolink can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign reolink Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[cdce8p]

If the check for new firmware fails, it will raise either a TimeoutError or UpdateFailed. Both will set last_updaate_success = False which in turn will set the available property to False. So this shouldn't be necessary.

core/homeassistant/components/reolink/__init__.py

Lines 85 to 91 in e00ff54

	async with async_timeout.timeout(host.api.timeout):
	try:
	return await host.api.check_new_firmware()
	except ReolinkError as err:
	raise UpdateFailed(
	f"Error checking Reolink firmware update {host.api.nvr_name}"
	) from err

[starkillerOG]

True, this can indeed be removed.

[starkillerOG]

True, this can indeed be removed.

[starkillerOG]

@cdce8p thanks for this PR!

[cdce8p]

@starkillerOG Would you mind to take a look at this again? I've rebased the PR and added ReolinkDeviceCoordinatorEntity as common base class.

[starkillerOG]

@cdce8p Alright I was very confused at first but now I do get it, but the naming is very confusing.
Please rename ReolinkDeviceCoordinatorEntity -> ReolinkHostCoordinatorEntity
and ReolinkCoordinatorEntity -> ReolinkChannelCoordinatorEntity

Please Update the ReolinkHostCoordinatorEntity description to:

    """Parent class for entities that control the Reolink NVR itself, without a channel.
    A camera connected directly to HomeAssistant without using a NVR is in the reolink API
    basically a NVR with a single channel that has the camera connected to that channel.
    """

Also please change the Base Coordinator description accordingly.

Unfortunatly the imports in all platforms will then also have to be updated (sorry).

[starkillerOG]

Looks good to me, appart for one docstring.

[frenck]

Thanks, @cdce8p 👍

../Frenck