Skip to content

Drop base ATTR constants in zeroconf#60561

Merged
frenck merged 8 commits intohome-assistant:devfrom
epenet:attr-zeroconf
Dec 1, 2021
Merged

Drop base ATTR constants in zeroconf#60561
frenck merged 8 commits intohome-assistant:devfrom
epenet:attr-zeroconf

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Nov 29, 2021

Breaking change

Not a breaking change if this is merged before 2021.12

Proposed change

Drop zeroconf constants created in #58671 and #58835.
Since ZeroconfServiceInfo was migrated to a dataclass, these should no longer be required.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (zeroconf) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@epenet epenet marked this pull request as ready for review December 1, 2021 09:19
@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Dec 1, 2021

In order to ensure can be merged before beta cut-off I have included lutron_caseta, samsungtv and xiaomi_miio

@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Dec 1, 2021

Phew this now passes.
@bdraco / @frenck could we merge this?

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks good, thanks @epenet 👍

@frenck frenck merged commit cbab0ba into home-assistant:dev Dec 1, 2021
@epenet epenet deleted the attr-zeroconf branch December 1, 2021 11:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants