Drop base ATTR constants in zeroconf#60561
Merged
frenck merged 8 commits intohome-assistant:devfrom Dec 1, 2021
Merged
Conversation
|
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
This was referenced Nov 30, 2021
4498460 to
03630c3
Compare
This was referenced Nov 30, 2021
2dbc72c to
880c1e9
Compare
Contributor
Author
|
In order to ensure can be merged before beta cut-off I have included |
Contributor
Author
This was referenced Dec 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Not a breaking change if this is merged before 2021.12
Proposed change
Drop zeroconf constants created in #58671 and #58835.
Since ZeroconfServiceInfo was migrated to a dataclass, these should no longer be required.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: