Skip to content

Add integration for Moonraker 3d printer service#60520

Closed
cmroche wants to merge 6 commits intohome-assistant:devfrom
cmroche:moonraker-dev
Closed

Add integration for Moonraker 3d printer service#60520
cmroche wants to merge 6 commits intohome-assistant:devfrom
cmroche:moonraker-dev

Conversation

@cmroche
Copy link
Copy Markdown
Contributor

@cmroche cmroche commented Nov 29, 2021

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@cmroche
Copy link
Copy Markdown
Contributor Author

cmroche commented Dec 1, 2021

Linting looks broken, it's referencing older code in zerconf, the attributes exist in dev. and pylint and mypy both run clean for me locally.

@frenck
Copy link
Copy Markdown
Member

frenck commented Dec 2, 2021

No linting is correct in this case, those are removed.

@Stevehans

This comment was marked as off-topic.

@cmroche

This comment was marked as off-topic.

@babybeliar

This comment was marked as off-topic.

@mikekay1

This comment was marked as off-topic.

@luci-11

This comment was marked as off-topic.

@ychieux

This comment was marked as off-topic.

@brujoand

This comment was marked as off-topic.

@cmroche
Copy link
Copy Markdown
Contributor Author

cmroche commented Aug 6, 2022

I have lots of updates ready to complete this integration too once this base PR is ready. We're closing in on a year without feedback, is there something else needed to complete the change for a merge?

@Bomberski

This comment was marked as off-topic.

node_name = local_name[: -len(".local")]
address = discovery_info.properties.get("address", discovery_info.host)

await self.async_set_unique_id(node_name)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node name is changeable, meaning we shouldn't use that as a unique ID.
Do we have another identifier we can use?

cmroche and others added 5 commits August 27, 2022 20:59
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@wuast94

This comment was marked as spam.

@cmroche
Copy link
Copy Markdown
Contributor Author

cmroche commented Dec 3, 2022

I'm closing this for now as I do not presently have much time to dedicate to this. The test repository still does work with current releases, hopefully either I, or someone will have some time to work on this in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.