Add integration for Moonraker 3d printer service#60520
Add integration for Moonraker 3d printer service#60520cmroche wants to merge 6 commits intohome-assistant:devfrom
Conversation
6c80a40 to
92f5357
Compare
|
Linting looks broken, it's referencing older code in zerconf, the attributes exist in dev. and pylint and mypy both run clean for me locally. |
|
No linting is correct in this case, those are removed. |
83c6b20 to
aba54b1
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
I have lots of updates ready to complete this integration too once this base PR is ready. We're closing in on a year without feedback, is there something else needed to complete the change for a merge? |
This comment was marked as off-topic.
This comment was marked as off-topic.
| node_name = local_name[: -len(".local")] | ||
| address = discovery_info.properties.get("address", discovery_info.host) | ||
|
|
||
| await self.async_set_unique_id(node_name) |
There was a problem hiding this comment.
The node name is changeable, meaning we shouldn't use that as a unique ID.
Do we have another identifier we can use?
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
This comment was marked as spam.
This comment was marked as spam.
|
I'm closing this for now as I do not presently have much time to dedicate to this. The test repository still does work with current releases, hopefully either I, or someone will have some time to work on this in the future. |
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: