Use dataclass properties in nanoleaf discovery

[epenet]

Proposed change

Use dataclass properties in nanoleaf discovery.

Linked to #60540

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[probot-home-assistant]

Hey there @milanmeu, mind taking a look at this pull request as it has been labeled with an integration (nanoleaf) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[epenet]

@milanmeu I did not update async_step_ssdp yet because I am not 100% sure if these three fields come from the SSDP headers or from the UPnP information:

core/homeassistant/components/nanoleaf/config_flow.py

Lines 119 to 123 in 0e3a229

	return await self._async_discovery_handler(
	discovery_info["_host"],
	discovery_info["nl-devicename"],
	discovery_info["nl-deviceid"],
	)

For the tests, I assumed it was UPnP but if I made a mistake then I can correct it in this PR :

core/tests/components/nanoleaf/test_config_flow.py

Lines 465 to 472 in 0e3a229

	data=ssdp.SsdpServiceInfo(
	ssdp_usn="mock_usn",
	ssdp_st="mock_st",
	upnp={
	"_host": TEST_HOST,
	"nl-devicename": TEST_NAME,
	"nl-deviceid": TEST_DEVICE_ID,
	},

If you do not have the opportunity to check it, then I suggest that we merge it as it is to avoid blocking #60561, and let the warning kick in when #60540 is merged.

[milanmeu]

According to the documentation, these come from the SSDP headers.

SSDP Docs

https://forum.nanoleaf.me/docs/openapi#_ndaoq4956f

[epenet]

I can adjust the tests for nl-devicename and nl-deviceid, but I do not see the _host header in the list. Is that definitely available in the ssdp headers?

[epenet]

Note: this PR is required for #60561

[milanmeu]

_host is a header. I'll ask someone from Nanoleaf to confirm and to update their docs. I don't know if there is another way to determine the IP address with SSDP.

SsdpServiceInfo

SsdpServiceInfo(
upnp={'UDN': 'uuid:f3e5a62e-7b85-4a94-a010-82797490743b'},
ssdp_usn='uuid:f3e5a62e-7b85-4a94-a010-82797490743b',
ssdp_st='nanoleaf:nl29',
ssdp_location='http://:16021',
ssdp_nt=None,
ssdp_udn='uuid:f3e5a62e-7b85-4a94-a010-82797490743b',
ssdp_ext='',
ssdp_server=None,
ssdp_headers={
 'S': 'uuid:f3e5a62e-7b85-4a94-a010-82797490743b',
 'Ext': '',
 'Cache-Control': 'no-cache="Ext",
 max-age = 60',
 'ST': 'nanoleaf:nl29',
 'USN': 'uuid:f3e5a62e-7b85-4a94-a010-82797490743b',
' nl-deviceid': '5E:2E:EA:4B:FA:F1',
 'nl-devicename': 'Canvas ADF9',
 '_location_original': 'http://:16021',
 'location': 'http://:16021',
 '_timestamp': datetime.datetime(2021, 11, 30, 11, 5, 41, 185416), 
 '_host': '192.168.0.236', 
 '_port': 1900,
 '_udn': 'uuid:f3e5a62e-7b85-4a94-a010-82797490743b'
},
x_homeassistant_matching_domains={'nanoleaf'},
_warning_logged=False
)

[epenet]

That's perfect. I've adjusted the tests and the code to take this into account.

[milanmeu]

Thanks @epenet 👍