Skip to content

Use dataclass properties in bosch_shc discovery#60559

Merged
frenck merged 2 commits intohome-assistant:devfrom
epenet:bosch-serviceinfo
Nov 30, 2021
Merged

Use dataclass properties in bosch_shc discovery#60559
frenck merged 2 commits intohome-assistant:devfrom
epenet:bosch-serviceinfo

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Nov 29, 2021

Proposed change

Use dataclass properties in bosch_shc discovery.

Linked to #60540

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @tschamm, mind taking a look at this pull request as it has been labeled with an integration (bosch_shc) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Comment on lines +194 to +196
discovery_info.host
if isinstance(discovery_info.host, list)
else [discovery_info.host]
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdraco can the host in zeroconf be a list?
Is it a mistake in my zeroconf type hint or is this a mistake in this integration?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AsyncServiceInfo returns a list, and we pick the address they hopefully want here:
https://github.com/home-assistant/core/blob/dev/homeassistant/components/zeroconf/__init__.py#L528

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the confirmation.
I have dropped multi-host handling from async_step_zeroconf and from the corresponding tests

@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Nov 30, 2021

Note: this is required for #60561

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@frenck frenck merged commit d537ec1 into home-assistant:dev Nov 30, 2021
@epenet epenet deleted the bosch-serviceinfo branch November 30, 2021 10:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants