Use dataclass properties in bosch_shc discovery#60559
Use dataclass properties in bosch_shc discovery#60559frenck merged 2 commits intohome-assistant:devfrom
Conversation
|
Hey there @tschamm, mind taking a look at this pull request as it has been labeled with an integration ( |
| discovery_info.host | ||
| if isinstance(discovery_info.host, list) | ||
| else [discovery_info.host] |
There was a problem hiding this comment.
@bdraco can the host in zeroconf be a list?
Is it a mistake in my zeroconf type hint or is this a mistake in this integration?
There was a problem hiding this comment.
AsyncServiceInfo returns a list, and we pick the address they hopefully want here:
https://github.com/home-assistant/core/blob/dev/homeassistant/components/zeroconf/__init__.py#L528
There was a problem hiding this comment.
Thanks for the confirmation.
I have dropped multi-host handling from async_step_zeroconf and from the corresponding tests
|
Note: this is required for #60561 |
Proposed change
Use dataclass properties in
bosch_shcdiscovery.Linked to #60540
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: