Skip to content

Use zeroconf attributes (A-D)#58835

Merged
bdraco merged 3 commits intohome-assistant:devfrom
epenet:zeroconf_attributes_followup
Nov 2, 2021
Merged

Use zeroconf attributes (A-D)#58835
bdraco merged 3 commits intohome-assistant:devfrom
epenet:zeroconf_attributes_followup

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Oct 31, 2021

Proposed change

Use zeroconf attributes (A-D)
Follow-up to #58671

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 31, 2021
Copy link
Copy Markdown
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is incomplete. Please perform the same changes to the tests. For axis integration do the same changes to the tests to get an approval

@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Oct 31, 2021

This PR is incomplete. Please perform the same changes to the tests. For axis integration do the same changes to the tests to get an approval

I thought it was better / easier to review if the changes to test were kept separate from the changes to component code.
If the same mistake is made in both the component and the code, then it might not get picked up.

@Kane610
Copy link
Copy Markdown
Member

Kane610 commented Oct 31, 2021

This PR is incomplete. Please perform the same changes to the tests. For axis integration do the same changes to the tests to get an approval

I thought it was better / easier to review if the changes to test were kept separate from the changes to component code. If the same mistake is made in both the component and the code, then it might not get picked up.

If you're next PR fixes the related tests that's fine by me

@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Oct 31, 2021

If you're next PR fixes the related tests that's fine by me

Sure, it will be my next PR...

Copy link
Copy Markdown
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to axis integration looks good

@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Oct 31, 2021

@Kane610 draft PR prepared: #58836

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Nov 2, 2021

In the future, it would be good to do less integrations and update the tests at the same time.

@bdraco bdraco merged commit e983370 into home-assistant:dev Nov 2, 2021
@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Nov 2, 2021

Thanks @bdraco
I felt it was safer to update separately the code and the tests, but I will follow those instructions going forward.
Hard to find the balance sometimes.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Nov 2, 2021

Thanks @bdraco I felt it was safer to update separately the code and the tests, but I will follow those instructions going forward. Hard to find the balance sometimes.

Should be safe if you:

  • Update the code
  • Run the test
  • Update the tests

@epenet epenet mentioned this pull request Nov 2, 2021
22 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2021
@epenet epenet deleted the zeroconf_attributes_followup branch November 16, 2021 11:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality Hacktoberfest hacktoberfest-accepted smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants