Use zeroconf attributes (A-D)#58835
Conversation
Kane610
left a comment
There was a problem hiding this comment.
This PR is incomplete. Please perform the same changes to the tests. For axis integration do the same changes to the tests to get an approval
I thought it was better / easier to review if the changes to test were kept separate from the changes to component code. |
If you're next PR fixes the related tests that's fine by me |
Sure, it will be my next PR... |
Kane610
left a comment
There was a problem hiding this comment.
Changes to axis integration looks good
|
In the future, it would be good to do less integrations and update the tests at the same time. |
|
Thanks @bdraco |
Should be safe if you:
|
Proposed change
Use zeroconf attributes (A-D)
Follow-up to #58671
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: