Use dataclass properties in lutron_caseta discovery#60629
Use dataclass properties in lutron_caseta discovery#60629epenet wants to merge 10 commits intohome-assistant:devfrom
Conversation
|
Hey there @swails, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
3708bbc to
4952512
Compare
|
@bdraco could you help me understand why my changes break the tests? |
|
@epenet looks like it was missing a |
|
|
|
nope, still failing passes locally for me though |
|
Yes it passes for me too |
|
Not sure one this one. This test needs to be modernized anyways. I'll take a look at cleaning it up when I have a larger time block free. |
|
I think its failing because of the split CI run. Likely any change to this integration will probably fail when not run with all the tests |
This reverts commit f50fce3.
|
The ciaomi miio case is different and will be fixed in a week or so (as Python 3.8 is being dropped for the 2022 dev) |
Proposed change
Use dataclass properties in
lutron_casetadiscovery.Linked to #60540
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: