Add config flow to iCloud#28968
Merged
Merged
Conversation
This was referenced Nov 22, 2019
f4021d2 to
5702452
Compare
balloob
reviewed
Nov 25, 2019
balloob
reviewed
Nov 25, 2019
balloob
reviewed
Nov 25, 2019
balloob
reviewed
Nov 25, 2019
balloob
reviewed
Nov 25, 2019
balloob
reviewed
Nov 25, 2019
balloob
reviewed
Nov 25, 2019
4 tasks
8 tasks
74c3fdd to
8df4d76
Compare
Member
Author
|
I've updated the description to follow the added breaking changes : the location of the iCloud cookie folder + the deletion of the reset service |
Member
|
Do the tests need updating to not do I/O? |
Member
Author
|
@MartinHjelmare : Yep, I'm working on it right now. Hope to make it work for 0.103.0 😄 |
Member
Author
Member
|
Why not patch the service class as we talked about above? |
Member
Author
|
Ok, just working in my computer, pushing |
Member
Author
|
@MartinHjelmare : What do you think of e2d040e ? |
33ac49d to
fc02053
Compare
Member
Author
|
What is the state of the PR now ? |
Member
|
There seems to be one line in the config flow that isn't covered by tests: |
- add config flow + tests - fix existing services - add play_sound & display_message services - document services - can use devices with the same name - prepare to add sensor platform
fc02053 to
33079eb
Compare
Member
Author
|
Got the 100% code coverage 😉 |
4 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Breaking Change:
The iCloud component leaves the device_tracker platform to become an integration.
From:
To:
Here are all the services :
SERVICE_ICLOUD_PLAY_SOUND = "play_sound"
SERVICE_ICLOUD_DISPLAY_MESSAGE = "display_message"
SERVICE_ICLOUD_LOST_DEVICE = "lost_device"
SERVICE_ICLOUD_UPDATE = "update"
Some services are renamed :
'icloud_lost_device' --> 'lost_device'
'icloud_update' --> 'update'
'icloud_reset' is removed
The iCloud cookie folder moved from
[HA_dir]/icloudto[HA_dir]/.storage/icloud.Description:
Dramatically improve the iCloud integration addition UX with config flow, translated steps (will do),
and list selection while choosing the trusted device (instead of a number).
It also adds documentation to services, and will fix issues.
Following the draft PR #24053 and crowded PR #26590
PR doing :
Related issue (if applicable):
fixes #13312
fixes #20195
fixes #28826
Pull request with documentation for home-assistant.io : home-assistant/home-assistant.io#11259
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.