Fix build, invalid JSON file in icloud component#29798
Merged
Merged
Conversation
probot-home-assistant
Bot
added
integration: icloud
small-pr
Member
|
What ? Build failed after #28968 ? How can it happens, since all checks passed in this previous iCloud PR 🤔 ? |
Member
Author
|
@Quentame We don't check if JSON files are valid in our builds. |
Member
|
I've just saw the PR, nice btw 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Our language uploads in the CI currently fail.
This is due to an invalid (JSON) translation file introduced in #28968
Related issue (if applicable): n/a
Pull request with documentation for home-assistant.io (if applicable): n/a
Example entry for
configuration.yaml(if applicable): n/aChecklist:
tox. Your PR cannot be merged unless tests pass