Add config flow to iCloud#26590
Conversation
|
@MartinHjelmare : I've take care of your reviews from the old PR #24053 and from the Linky one #26076. But I've still some issues to understand coroutine stuff, use of Also, the |
MartinHjelmare
left a comment
There was a problem hiding this comment.
I haven't looked at the config flow or the tests yet.
|
@MartinHjelmare : Is it possible to make my |
|
Entities with latitude and longitude as state attributes should be visible on the map by default. |
c5112cf to
42773ba
Compare
f9f2770 to
0b5d8bd
Compare
|
@MartinHjelmare : devices are displayed in the map (actually some kind of not showing when home and position updates made me think that). Do you know how to add the battery infos on the new config -> devices panel ? I tried multiple key in the |
|
It's not possible to add custom keys to device_info. Only the keys in the docs are available to be set: Probably create a separate sensor, measuring battery level, and make sure the sensor has the device id of the device in question in the device_info. |
|
Okey @MartinHjelmare, will do it in a next PR, with the sensor |
0b5d8bd to
0198ad1
Compare
072f268 to
f34a7b3
Compare
|
I'm kinda stuck with the tests, can you take a quick look @MartinHjelmare ? Thanks a lot. |
5ee9b15 to
3ad12f8
Compare
+ add return types
Thanks a lot @MartinHjelmare
22c10df to
7e3fdd7
Compare
|
The pipeline is passing @MartinHjelmare I'm gonna work on the documentation then. |
|
Opened a fresh PR #28968 |

Breaking Change:
The iCloud component leaves the device_tracker platform to become an integration.
From:
To:
Here are all the services :
SERVICE_ICLOUD_PLAY_SOUND = "play_sound"
SERVICE_ICLOUD_DISPLAY_MESSAGE = "display_message"
SERVICE_ICLOUD_LOST_DEVICE = "lost_device"
SERVICE_ICLOUD_UPDATE = "update"
SERVICE_ICLOUD_RESET = "reset"
Some services are renamed :
'icloud_lost_device' --> 'lost_device'
'icloud_update' --> 'update'
'icloud_reset' --> 'reset'
Description:
Dramatically improve the iCloud integration addition UX with config flow, translated steps (will do),
and list selection while choosing the trusted device (instead of a number).
It also adds documentation to services, and should fix two issues.
Following the draft PR #24053
PR doing :
Related issue (if applicable):
fixes #13312
fixes #20195
fixes #28826
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
NOT YET
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.