Skip to content

Add config flow to iCloud#11259

Merged
frenck merged 4 commits into
home-assistant:nextfrom
Quentame:icloud/config-flow
Dec 9, 2019
Merged

Add config flow to iCloud#11259
frenck merged 4 commits into
home-assistant:nextfrom
Quentame:icloud/config-flow

Conversation

@Quentame
Copy link
Copy Markdown
Member

@Quentame Quentame commented Nov 22, 2019

Description:

Following home-assistant/core#28968

Pull request in home-assistant: home-assistant/core#28968

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Nov 22, 2019
@Quentame Quentame marked this pull request as ready for review November 22, 2019 23:19
@Quentame
Copy link
Copy Markdown
Member Author

Quentame commented Dec 4, 2019

@klaasnicolaas can you take a look ?

The parent PR is almost ready 😊

Thanks

@frenck
Copy link
Copy Markdown
Member

frenck commented Dec 5, 2019

@Quentame Please don't tag random members to ask for a review. Thanks 👍

Regarding this PR, it will get a review before the release the parent PR is in for sure. 👍

@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Dec 5, 2019
@probot-home-assistant probot-home-assistant Bot added the parent-merged The parent PR has been merged already label Dec 9, 2019
@frenck
Copy link
Copy Markdown
Member

frenck commented Dec 9, 2019

@Quentame Adjusted (and moved it a bit).

@frenck frenck merged commit 9cd1835 into home-assistant:next Dec 9, 2019
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Dec 9, 2019
@Quentame Quentame deleted the icloud/config-flow branch December 9, 2019 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants