Add battery sensor to iCloud#29818
Merged
MartinHjelmare merged 4 commits intoDec 14, 2019
Merged
Conversation
Quentame
force-pushed
the
icloud/add-battery-sensor
branch
2 times, most recently
from
4d36ea5 to
a3fa8fe
Compare
2 tasks
balloob
reviewed
Dec 13, 2019
balloob
reviewed
Dec 13, 2019
balloob
approved these changes
Dec 13, 2019
MartinHjelmare
requested changes
Dec 13, 2019
Quentame
force-pushed
the
icloud/add-battery-sensor
branch
from
0f565ea to
c61d7f2
Compare
Quentame
commented
Dec 13, 2019
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Do we want to use the builtin update interval or should we connect a state update to the dispatch helper signal, for the sensor?
Member
Author
|
I think that would be better with a dispatch signal, it’s gonna avoid the 30s default and when iCloud interval is 1 min sensors are updated in HA for 1 min 30 actually. Will look into it. |
Member
|
We can also look into it at the next PR |
MartinHjelmare
approved these changes
Dec 14, 2019
Member
|
Can be merged when build passes. |
Member
Author
|
build passes 😊 |
Member
Author
|
I've just added the dispatch signal in this PR #30680 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
None, addition
Description:
Follows #28968
Add battery sensor for each iDevice of your account.
Pull request with documentation for home-assistant.io : home-assistant/home-assistant.io#11434
iCloud device list
iCloud device details
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.