Add Plex config flow support#26548
Merged
MartinHjelmare merged 39 commits intoSep 19, 2019
Merged
Conversation
MartinHjelmare
requested changes
Sep 10, 2019
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
The config flow requires 100 % test coverage. Make sure it's not excluded from test coverage and see eg hue config flow tests for test examples.
5 tasks
jjlawren
force-pushed
the
plex_config_flow_v2
branch
from
4faf046 to
220fb07
Compare
Kane610
reviewed
Sep 17, 2019
Kane610
approved these changes
Sep 18, 2019
Member
Kane610
left a comment
Kane610
left a comment
There was a problem hiding this comment.
Looks good to me, but mainly focused on the config entries
2 tasks
This was referenced Sep 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add support for config flow setup for Plex. Major changes:
configuratorsetupA continuation from #26157 and #26488, #26583
Related issue (if applicable): fixes #18113 #22973
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10389
Example entry for
configuration.yaml(if applicable):Legacy configurations are accepted and imported to a config entry.
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.