Move config and connections to Plex component#26488
Merged
Merged
Conversation
MartinHjelmare
requested changes
Sep 7, 2019
2 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Configuration is moved from the
media_playerandsensorplatforms to theplexcomponent. Existing configurations will need to be updated. Theremove_unavailable_clientsandclient_remove_intervaloptions formedia_playerentities have been removed as the functionality has limited value now that the entity registry exists.The
plexcomponent will now enable bothsensorandmedia_playerplatforms by default, sharing the same credentials.Old example:
New example:
Description:
A continuation from #26157 and #26458.
Configuration for the
media_playerandsensorplexplatforms have been merged into a shared configuration. Connection logic has been centralized and both platforms now share the same connection object. The legacyconfiguratorconfiguration method has been preserved and now works for both platforms instead of justmedia_player. Discovery has also been modified to load theplexcomponent instead of the Plexmedia_playercomponent.Pull request with documentation for home-assistant.io (if applicable):
home-assistant/home-assistant.io#10328
Example entry for
configuration.yaml(if applicable):See Breaking Change above.
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: