Standardize Plex server connections#26444
Merged
Merged
Conversation
MartinHjelmare
requested changes
Sep 5, 2019
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
…ant into plex_central_server
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
Member
|
Should we also consider changing the configuration to being included under the |
Member
|
Yeah, we're talking about that. But it's not for this PR. |
2 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Logins using a username/password/servername are no longer supported on the Plex
sensorplatform. This functionality will be partially restored in followup PRs which add a configuration flow and external authentication.Description:
First step in using common code between the Plex
media_playerandsensorplatforms. This adds a common class to connect to Plex servers.This is a smaller part of #26157.
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10297
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
.coveragerc.