Skip to content

Standardize Plex server connections#26444

Merged
MartinHjelmare merged 22 commits into
home-assistant:devfrom
jjlawren:plex_central_server
Sep 5, 2019
Merged

Standardize Plex server connections#26444
MartinHjelmare merged 22 commits into
home-assistant:devfrom
jjlawren:plex_central_server

Conversation

@jjlawren
Copy link
Copy Markdown
Contributor

@jjlawren jjlawren commented Sep 5, 2019

Breaking Change:

Logins using a username/password/servername are no longer supported on the Plex sensor platform. This functionality will be partially restored in followup PRs which add a configuration flow and external authentication.

Description:

First step in using common code between the Plex media_player and sensor platforms. This adds a common class to connect to Plex servers.

This is a smaller part of #26157.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10297

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: plex
    host: 192.168.1.5
    token: abc1234xyz

media_player:
  - platform: plex

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Untested files have been added to .coveragerc.

@jjlawren jjlawren marked this pull request as ready for review September 5, 2019 06:03
Comment thread homeassistant/components/plex/media_player.py Outdated
Comment thread homeassistant/components/plex/media_player.py Outdated
Comment thread homeassistant/components/plex/media_player.py Outdated
Comment thread homeassistant/components/plex/sensor.py Outdated
Comment thread homeassistant/components/plex/server.py Outdated
Comment thread homeassistant/components/plex/server.py Outdated
Comment thread homeassistant/components/plex/sensor.py
Comment thread homeassistant/components/plex/sensor.py Outdated
Comment thread homeassistant/components/plex/server.py Outdated
Comment thread homeassistant/components/plex/server.py
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@dshokouhi
Copy link
Copy Markdown
Member

Should we also consider changing the configuration to being included under the plex: domain? I know might be out of scope of this PR but I figured this integration should become like the others where it discovers the media player and sensor after accessing the server.

@MartinHjelmare
Copy link
Copy Markdown
Member

Yeah, we're talking about that. But it's not for this PR.

@MartinHjelmare MartinHjelmare merged commit 2cd845f into home-assistant:dev Sep 5, 2019
@jjlawren jjlawren deleted the plex_central_server branch September 5, 2019 18:43
@lock lock Bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants